summaryrefslogtreecommitdiffstats
path: root/tools/check_git_config.py
diff options
context:
space:
mode:
authorkareng <kareng@google.com>2014-09-30 14:35:19 -0700
committerCommit bot <commit-bot@chromium.org>2014-09-30 21:35:35 +0000
commite10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd (patch)
treef8ebbf2e93a97ca5283d153a0772274d81cdd7b2 /tools/check_git_config.py
parentc26c106e7724c400fed9980ce371a1c81d1af849 (diff)
downloadchromium_src-e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd.zip
chromium_src-e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd.tar.gz
chromium_src-e10fb6c6993651bfcfa26c0d28d83a6cbabb4ffd.tar.bz2
Revert of Pending tasks in a message loop should be deleted before shutting down Blink (patchset #9 id:160001 of https://codereview.chromium.org/583043005/)
Reason for revert: BUG=418206 broke canary AGAIN! please do NOT reland without fixing! https://code.google.com/p/chromium/issues/detail?id=418206 Original issue's description: > Pending tasks in a message loop should be deleted before shutting down Blink > > Currently Blink is shut down before all the pending tasks in the message loop are deleted. This is problematic in Oilpan because a destructor of the pending tasks can touch Oilpan objects. Because Oilpan is already detached from the renderer thread at that point, touching Oilpan objects in the destructor leads to a crash. (See the bug report for a concrete scenario.) > > To prevent Blink objects from getting accessed after Blink is shut down, this CL deletes all pending tasks in a message loop before shutting down Blink. > > BUG=411026 > TEST=None. I cannot reproduce the crash. > > Committed: https://crrev.com/fdd5612c20f777e1279efd7c1e99d82ed04afaaf > Cr-Commit-Position: refs/heads/master@{#296697} > > Committed: https://crrev.com/16d32a9f7f6d1ebb639cacedb5156272a9fec764 > Cr-Commit-Position: refs/heads/master@{#297338} TBR=tkent@chromium.org,jochen@chromium.org,jamesr@chromium.org,ager@chromium.org,jar@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=411026 Review URL: https://codereview.chromium.org/614233002 Cr-Commit-Position: refs/heads/master@{#297506}
Diffstat (limited to 'tools/check_git_config.py')
0 files changed, 0 insertions, 0 deletions