diff options
| author | sclittle <sclittle@chromium.org> | 2015-03-05 11:04:18 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-05 19:05:05 +0000 |
| commit | b95593d7a0712445b42a27ba27065434797e95a2 (patch) | |
| tree | 48e9c89c54de795733890000313d90686713dc19 /tools/chrome_proxy | |
| parent | 78af6b39bd901c60fcc4e345dd0488fce9eb0439 (diff) | |
| download | chromium_src-b95593d7a0712445b42a27ba27065434797e95a2.zip chromium_src-b95593d7a0712445b42a27ba27065434797e95a2.tar.gz chromium_src-b95593d7a0712445b42a27ba27065434797e95a2.tar.bz2 | |
Use google favicon URL for the HTTPFallbackProbe Data Saver test.
This test was failing for a while because
http://chromeproxy-test.appspot.com/default?respBody=bm90IE9L was really
slow to respond. This change changes the secure proxy check URL to the
google.com favicon, which will also fail but should have more
reliable latency.
BUG=463704
Review URL: https://codereview.chromium.org/975223002
Cr-Commit-Position: refs/heads/master@{#319291}
Diffstat (limited to 'tools/chrome_proxy')
| -rw-r--r-- | tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py index 7fe40df..fcbba64 100644 --- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py +++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py @@ -217,11 +217,14 @@ class ChromeProxyHTTPFallbackProbeURL(ChromeProxyValidation): def CustomizeBrowserOptions(self, options): super(ChromeProxyHTTPFallbackProbeURL, self).CustomizeBrowserOptions(options) - # Use the test server probe URL which returns the response - # body as specified by respBody. - probe_url = GetResponseOverrideURL(respBody='not OK') + # Set the secure proxy check URL to the google.com favicon, which will be + # interpreted as a secure proxy check failure since the response body is not + # "OK". The google.com favicon is used because it will load reliably fast, + # and there have been problems with chromeproxy-test.appspot.com being slow + # and causing tests to flake. options.AppendExtraBrowserArgs( - '--data-reduction-proxy-secure-proxy-check-url=%s' % probe_url) + '--data-reduction-proxy-secure-proxy-check-url=' + 'http://www.google.com/favicon.ico') def AddResults(self, tab, results): self._metrics.AddResultsForHTTPFallback(tab, results) |