diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-29 21:40:09 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-29 21:40:09 +0000 |
| commit | e084eaa719ae7b42ab0b135d94ce7c0effbda105 (patch) | |
| tree | 24824f94ccfb8e89f71fb6bdd93aa4af1f88b01e /tools/code_coverage/coverage_posix.py | |
| parent | 99cc0e2927709ccc01e32b3e4caea7d2b591a5ca (diff) | |
| download | chromium_src-e084eaa719ae7b42ab0b135d94ce7c0effbda105.zip chromium_src-e084eaa719ae7b42ab0b135d94ce7c0effbda105.tar.gz chromium_src-e084eaa719ae7b42ab0b135d94ce7c0effbda105.tar.bz2 | |
Do not make test failures fatal (since it is so common.)
Review URL: http://codereview.chromium.org/522021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35348 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/code_coverage/coverage_posix.py')
| -rwxr-xr-x | tools/code_coverage/coverage_posix.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/code_coverage/coverage_posix.py b/tools/code_coverage/coverage_posix.py index 13835dc..2336f1d 100755 --- a/tools/code_coverage/coverage_posix.py +++ b/tools/code_coverage/coverage_posix.py @@ -237,7 +237,7 @@ class Coverage(object): """Run all unit tests and generate appropriate lcov files.""" for fulltest in self.tests: if not os.path.exists(fulltest): - logging.fatal(fulltest + ' does not exist') + logging.info(fulltest + ' does not exist') if self.options.strict: sys.exit(2) else: @@ -260,9 +260,10 @@ class Coverage(object): self.AfterRunOneTest(fulltest) if retcode: - logging.fatal('COVERAGE: test %s failed; return code: %d' % + logging.info('COVERAGE: test %s failed; return code: %d.' % (fulltest, retcode)) if self.options.strict: + logging.fatal('Test failure is fatal.') sys.exit(retcode) self.AfterRunAllTests() |