summaryrefslogtreecommitdiffstats
path: root/tools/cygprofile
diff options
context:
space:
mode:
authorpasko <pasko@chromium.org>2015-11-19 12:25:56 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-19 20:26:38 +0000
commit354c7c01fde29a5b7200403c2a730da6515f5b88 (patch)
treebebef383be28a7f37c24227a28d18e6c258d0b16 /tools/cygprofile
parent906985683380f98103092da34fe7bc4c2a65b564 (diff)
downloadchromium_src-354c7c01fde29a5b7200403c2a730da6515f5b88.zip
chromium_src-354c7c01fde29a5b7200403c2a730da6515f5b88.tar.gz
chromium_src-354c7c01fde29a5b7200403c2a730da6515f5b88.tar.bz2
Mechanically change TODO(azarchs) into TODO(pasko)
.. since azarchs left the team BUG=none Review URL: https://codereview.chromium.org/1462503002 Cr-Commit-Position: refs/heads/master@{#360653}
Diffstat (limited to 'tools/cygprofile')
-rw-r--r--tools/cygprofile/cygprofile.gyp2
-rwxr-xr-xtools/cygprofile/cygprofile_utils.py4
-rwxr-xr-xtools/cygprofile/patch_orderfile.py4
-rw-r--r--tools/cygprofile/profile_android_startup.py4
-rwxr-xr-xtools/cygprofile/symbol_extractor.py3
5 files changed, 9 insertions, 8 deletions
diff --git a/tools/cygprofile/cygprofile.gyp b/tools/cygprofile/cygprofile.gyp
index c0deded..5fd543b 100644
--- a/tools/cygprofile/cygprofile.gyp
+++ b/tools/cygprofile/cygprofile.gyp
@@ -30,7 +30,7 @@
'cygprofile_unittest.cc',
],
'cflags!': [ '-finstrument-functions' ],
- # TODO(azarchs): Fix the underlying problem (crbug/485542)
+ # TODO(lizeb,pasko): Fix the underlying problem (crbug/485542)
'ldflags': [ '-Wl,--no-fatal-warnings' ],
'dependencies': [
'cygprofile',
diff --git a/tools/cygprofile/cygprofile_utils.py b/tools/cygprofile/cygprofile_utils.py
index 4851df9..4219a15 100755
--- a/tools/cygprofile/cygprofile_utils.py
+++ b/tools/cygprofile/cygprofile_utils.py
@@ -58,7 +58,7 @@ def GetObjDir(libchrome):
Assumes libchrome is in for example .../Release/lib/libchrome.so and object
files are in .../Release/obj.
"""
- # TODO(azarchs): Pass obj path in explicitly where needed rather than relying
- # on the above assumption.
+ # TODO(lizeb,pasko): Pass obj path in explicitly where needed rather than
+ # relying on the above assumption.
return os.path.abspath(os.path.join(
os.path.dirname(libchrome), '../obj'))
diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py
index 0092ddd..dbb344f 100755
--- a/tools/cygprofile/patch_orderfile.py
+++ b/tools/cygprofile/patch_orderfile.py
@@ -187,7 +187,7 @@ def GetSymbolsFromOrderfile(filename, section_to_symbols_map):
Yields:
A list of symbol names.
"""
- # TODO(azarchs): Move this method to symbol_extractor.py
+ # TODO(lizeb,pasko): Move this method to symbol_extractor.py
for section in GetSectionsFromOrderfile(filename):
for symbol in _SectionNameToSymbols(RemoveSuffixes(section),
section_to_symbols_map):
@@ -250,7 +250,7 @@ def _SectionMatchingRules(section_name, name_to_symbol_infos,
# suffixes, don't emit the wildcards for ones where it won't be helpful.
# Otherwise linking takes too long.
if name in suffixed_sections:
- # TODO(azarchs): instead of just appending .*, append .suffix.* for
+ # TODO(lizeb,pasko): instead of just appending .*, append .suffix.* for
# _SUFFIXES. We can't do this right now because that many wildcards
# seems to kill the linker (linking libchrome takes 3 hours). This gets
# almost all the benefit at a much lower link-time cost, but could cause
diff --git a/tools/cygprofile/profile_android_startup.py b/tools/cygprofile/profile_android_startup.py
index 2543b86..6dbf0ea 100644
--- a/tools/cygprofile/profile_android_startup.py
+++ b/tools/cygprofile/profile_android_startup.py
@@ -79,7 +79,7 @@ class WprManager(object):
def Start(self):
"""Set up the device and host for WPR."""
self.Stop()
- #TODO(azarchs): make self._InstallTestCa() work
+ # TODO(lizeb,pasko): make self._InstallTestCa() work
self._BringUpWpr()
self._StartForwarder()
@@ -87,7 +87,7 @@ class WprManager(object):
"""Clean up the device and host's WPR setup."""
self._StopForwarder()
self._StopWpr()
- #TODO(azarchs): make self._RemoveTestCa() work
+ # TODO(lizeb,pasko): make self._RemoveTestCa() work
def __enter__(self):
self.Start()
diff --git a/tools/cygprofile/symbol_extractor.py b/tools/cygprofile/symbol_extractor.py
index a30c05e..d709117 100755
--- a/tools/cygprofile/symbol_extractor.py
+++ b/tools/cygprofile/symbol_extractor.py
@@ -137,7 +137,8 @@ def CreateNameToSymbolInfo(symbol_infos):
If a symbol name corresponds to more than one symbol_info, the symbol_info
with the lowest offset is chosen.
"""
- #TODO(azarchs): move the functionality in this method into check_orderfile.
+ # TODO(lizeb,pasko): move the functionality in this method into
+ # check_orderfile.
symbol_infos_by_name = {}
warnings = cygprofile_utils.WarningCollector(_MAX_WARNINGS_TO_PRINT)
for infos in GroupSymbolInfosByName(symbol_infos).itervalues():