diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-19 22:52:16 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-19 22:54:04 +0000 |
commit | 0dfcae783a9285e3a3099f7098f076ef7b093f6e (patch) | |
tree | 543118667a7393e30934ae7c14050d4686219657 /tools/gn/config_values_extractors_unittest.cc | |
parent | c9a47cccedaa0556b52c1ceeb6c6a0d0b2f018f9 (diff) | |
download | chromium_src-0dfcae783a9285e3a3099f7098f076ef7b093f6e.zip chromium_src-0dfcae783a9285e3a3099f7098f076ef7b093f6e.tar.gz chromium_src-0dfcae783a9285e3a3099f7098f076ef7b093f6e.tar.bz2 |
Support more configurability in GN toolchains
This uses substitution patterns in toolchains to allow the toolchain to specify more flexibly how files are to be named and generated at each step. The toolchain now has control over the naming of object and executable files, for example, where before these were hardcoded.
This removes most of the OS-specific logic hardcoded into the GN tool. There is still a bunch in action invocation; this will be done in a followup.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/440333002
Cr-Commit-Position: refs/heads/master@{#290685}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290685 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/gn/config_values_extractors_unittest.cc')
-rw-r--r-- | tools/gn/config_values_extractors_unittest.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/gn/config_values_extractors_unittest.cc b/tools/gn/config_values_extractors_unittest.cc index 0076b9e..a408226 100644 --- a/tools/gn/config_values_extractors_unittest.cc +++ b/tools/gn/config_values_extractors_unittest.cc @@ -45,6 +45,7 @@ TEST(ConfigValuesExtractors, IncludeOrdering) { Target dep2(setup.settings(), Label(SourceDir("//dep2/"), "dep2")); dep2.set_output_type(Target::SOURCE_SET); + dep2.SetToolchain(setup.toolchain()); dep2.all_dependent_configs().push_back(LabelConfigPair(&dep2_all)); dep2.direct_dependent_configs().push_back(LabelConfigPair(&dep2_direct)); @@ -60,6 +61,7 @@ TEST(ConfigValuesExtractors, IncludeOrdering) { Target dep1(setup.settings(), Label(SourceDir("//dep1/"), "dep1")); dep1.set_output_type(Target::SOURCE_SET); + dep1.SetToolchain(setup.toolchain()); dep1.all_dependent_configs().push_back(LabelConfigPair(&dep1_all)); dep1.direct_dependent_configs().push_back(LabelConfigPair(&dep1_direct)); dep1.deps().push_back(LabelTargetPair(&dep2)); @@ -85,6 +87,7 @@ TEST(ConfigValuesExtractors, IncludeOrdering) { Target target(setup.settings(), Label(SourceDir("//target/"), "target")); target.set_output_type(Target::SOURCE_SET); + target.SetToolchain(setup.toolchain()); target.all_dependent_configs().push_back(LabelConfigPair(&target_all)); target.direct_dependent_configs().push_back(LabelConfigPair(&target_direct)); target.configs().push_back(LabelConfigPair(&target_config)); |