diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-07 22:17:35 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-07 22:17:35 +0000 |
| commit | 126d8b5e3a7efa3e2584de4c1bc31c6460233ca6 (patch) | |
| tree | 91c7311d1161422ffdf91b9ce0a222a345c03ffe /tools/gn/filesystem_utils.h | |
| parent | 44b4f0e59d30953db7cd89dd95266f0f5973e1da (diff) | |
| download | chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.zip chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.tar.gz chromium_src-126d8b5e3a7efa3e2584de4c1bc31c6460233ca6.tar.bz2 | |
Add optional public header checking to GN build
You can invoke this either using the "--check" argument to the gen command (for use on buildbots) or by running "gn check" (for developer on-demand use).
This adds support for "public" headers for a target, and an optional "--check" flag to the gen command that implements checkdeps-like include checking. Basically if you include a file that's declared in the build, it has to be in the public section of one of your dependents (or that dependent doesn't have a public section, which implies everything is public).
This roughly maps to Blaze's behavior around the public headers.
Moves modp_b64 build file to main tree.
Remove modp_b64 hack for older versions of VC missing stdint (this included basictypes which caused a header check failure).
I also added some base dependencies and some other minor build changes to solve some other issues identified by the check. The remaining one is that a file in base/metrics depends on ipc (!)
BUG=
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/216903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262216 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/gn/filesystem_utils.h')
| -rw-r--r-- | tools/gn/filesystem_utils.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/gn/filesystem_utils.h b/tools/gn/filesystem_utils.h index d2658c2..a6bb0fe 100644 --- a/tools/gn/filesystem_utils.h +++ b/tools/gn/filesystem_utils.h @@ -28,8 +28,7 @@ enum SourceFileType { SOURCE_RC, }; -SourceFileType GetSourceFileType(const SourceFile& file, - Settings::TargetOS os); +SourceFileType GetSourceFileType(const SourceFile& file); // Returns the extension, not including the dot, for the given file type on the // given system. |