Revert 262747 "Improve GN public header file checking"

It failed Win x64 Builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17043/steps/compile/logs/stdio

> Improve GN public header file checking
> 
> This makes the header checker and include iterator work from InputFiles (which basically just hold the file buffer) rather than just raw strings. This allows us to reference these files from Err.
> 
> Some extra line/char tracking is now in the include iterator so we can actually quote from and annotate the place in the source file where the bad include is, which looks much nicer than "the file blah included blah". It also makes it possible to write much shorter error messages that still make sense.
> 
> This adds visibility checking as previously documented in the help for "public" and a unit test for that.
> 
> This updates the documentation for "public" which was wrong (it referred to patterns which was not used).
> 
> R=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/229423002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/231293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262755 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 7 deletions

diff --git a/tools/gn/header_checker.h b/tools/gn/header_checker.h
index f62ca2c..f1c7aa3 100644
--- a/tools/gn/header_checker.h
+++ b/tools/gn/header_checker.h
@@ -18,9 +18,7 @@
 #include "tools/gn/err.h"
 
 class BuildSettings;
-class InputFile;
 class Label;
-class LocationRange;
 class SourceFile;
 class Target;
 
@@ -73,13 +71,10 @@ class HeaderChecker : public base::RefCountedThreadSafe<HeaderChecker> {
                  Err* err) const;
 
   // Checks that the given file in the given target can include the given
-  // include file. If disallowed, returns false and sets the error. The
-  // range indicates the location of the include in the file for error
-  // reporting.
+  // include file. If disallowed, returns false and sets the error.
   bool CheckInclude(const Target* from_target,
-                    const InputFile& source_file,
+                    const SourceFile& source_file,
                     const SourceFile& include_file,
-                    const LocationRange& range,
                     Err* err) const;
 
   // Returns true if the given search_for target is a dependency of