summaryrefslogtreecommitdiffstats
path: root/tools/gn/ninja_target_writer_unittest.cc
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-02 22:36:29 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-02 22:36:29 +0000
commit3098afac51683f68dce4391bad9b86e87e02c1dc (patch)
tree921dcdc342209690017cdff39aed8820b57b4f24 /tools/gn/ninja_target_writer_unittest.cc
parentba8addaa77edccfc1e5062d6328a22130bd3fae3 (diff)
downloadchromium_src-3098afac51683f68dce4391bad9b86e87e02c1dc.zip
chromium_src-3098afac51683f68dce4391bad9b86e87e02c1dc.tar.gz
chromium_src-3098afac51683f68dce4391bad9b86e87e02c1dc.tar.bz2
Support deps for actions in GN.
Previously GN did not write out any ninja code for deps and datadeps. This patch adds that and also documentation for how deps work for actions. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/265703008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267945 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/gn/ninja_target_writer_unittest.cc')
-rw-r--r--tools/gn/ninja_target_writer_unittest.cc14
1 files changed, 9 insertions, 5 deletions
diff --git a/tools/gn/ninja_target_writer_unittest.cc b/tools/gn/ninja_target_writer_unittest.cc
index d542147..6954cfa 100644
--- a/tools/gn/ninja_target_writer_unittest.cc
+++ b/tools/gn/ninja_target_writer_unittest.cc
@@ -21,8 +21,9 @@ class TestingNinjaTargetWriter : public NinjaTargetWriter {
virtual void Run() OVERRIDE {}
// Make this public so the test can call it.
- std::string WriteInputDepsStampAndGetDep() {
- return NinjaTargetWriter::WriteInputDepsStampAndGetDep();
+ std::string WriteInputDepsStampAndGetDep(
+ const std::vector<const Target*>& extra_hard_deps) {
+ return NinjaTargetWriter::WriteInputDepsStampAndGetDep(extra_hard_deps);
}
};
@@ -58,7 +59,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&base_target, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_TRUE(dep.empty());
EXPECT_TRUE(stream.str().empty());
@@ -68,7 +70,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&target, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_EQ(" | obj/foo/target.inputdeps.stamp", dep);
EXPECT_EQ("obj/foo/target.inputdeps.stamp: stamp "
@@ -81,7 +84,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&action, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_EQ(" | obj/foo/action.inputdeps.stamp", dep);
EXPECT_EQ("obj/foo/action.inputdeps.stamp: stamp "