diff options
author | dpranke <dpranke@chromium.org> | 2015-07-27 16:10:31 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-27 23:11:14 +0000 |
commit | 61fb6826c8e7b9a31c260cb3698258e4fad5b33b (patch) | |
tree | 150b090a8d64ed822b24e3e42cbfa9d24e8ddcd3 /tools/gn/scheduler.cc | |
parent | 8c8c674234a53e44e8621baff460ec1343992b8c (diff) | |
download | chromium_src-61fb6826c8e7b9a31c260cb3698258e4fad5b33b.zip chromium_src-61fb6826c8e7b9a31c260cb3698258e4fad5b33b.tar.gz chromium_src-61fb6826c8e7b9a31c260cb3698258e4fad5b33b.tar.bz2 |
Revert of Add output reference to gen written files. (patchset #3 id:40001 of https://codereview.chromium.org/1220223002/)
Reason for revert:
Looks like this doesn't quite work on Windows:
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/21206/steps/compile%20%28with%20patch%29/logs/stdio
Original issue's description:
> Add output reference to gen written files.
>
> By adding the outputs written at gn gen time to the build.ninja representation the build tool (ninja) can know how to recreate them if and when necessary.
>
> For example, if one or more of the <blah>.tmp files is removed, even as part of an entire hierarchy/subtree currently the build fails because ninja does not know how to re-make it.
>
> BUG=469621
> TEST=Build time only. See https://code.google.com/p/chromium/issues/detail?id=469621#c3
>
> Committed: https://crrev.com/517ac52f86903beb206b19e6ddeedbc709b253a1
> Cr-Commit-Position: refs/heads/master@{#338929}
TBR=brettw@chromium.org,petermayo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469621
Review URL: https://codereview.chromium.org/1255113004
Cr-Commit-Position: refs/heads/master@{#340596}
Diffstat (limited to 'tools/gn/scheduler.cc')
-rw-r--r-- | tools/gn/scheduler.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/tools/gn/scheduler.cc b/tools/gn/scheduler.cc index db0929d..622019e 100644 --- a/tools/gn/scheduler.cc +++ b/tools/gn/scheduler.cc @@ -113,11 +113,6 @@ void Scheduler::AddWrittenFile(const SourceFile& file) { written_files_.push_back(file); } -std::vector<SourceFile> Scheduler::GetWrittenFiles() const { - base::AutoLock lock(lock_); - return written_files_; -} - void Scheduler::AddUnknownGeneratedInput(const Target* target, const SourceFile& file) { base::AutoLock lock(lock_); |