diff options
| author | sdefresne <sdefresne@chromium.org> | 2015-07-30 01:05:54 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-30 08:06:36 +0000 |
| commit | 6e883e40d456dd422ac08ced1c25e7403f78bada (patch) | |
| tree | 615f0986f2edb95b679d1598eaaff335e29283f1 /tools/gritsettings | |
| parent | 0289a621d385a5fa87f3635bedaae2daabc6f4b9 (diff) | |
| download | chromium_src-6e883e40d456dd422ac08ced1c25e7403f78bada.zip chromium_src-6e883e40d456dd422ac08ced1c25e7403f78bada.tar.gz chromium_src-6e883e40d456dd422ac08ced1c25e7403f78bada.tar.bz2 | |
Componentize VersionInfo.
Create a new component version_info that allows to get information about
the current version of Chrome running, except for the channel (which has
to be provided by the embedder).
The method to get the channel is not moved to the component because on
Windows it depends on //chrome/installer which would be non-trivial to
componentize. Since the method is embedder-specific (though it have no
bad dependencies on the other platform) it makes sense to not move it
into the component.
Fixes VersionInfo API to only expose static method (since the class did
not have any state and the API was a mix of "const" and "static" methods)
and to delegate the job to version_info component in order to limit the
API changes.
Mass rename (chrome::)VersionInfo::(Channel|CHANNEL) after the enum was
moved to the version_info namespace in the corresponding component using
tools/git/mffr.py.
Change Channel enumeration to be a "class enum" and add static_cast<int>
where needed (as class enum do not implicitly convert to int).
BUG=511912
Review URL: https://codereview.chromium.org/1257633002
Cr-Commit-Position: refs/heads/master@{#341085}
Diffstat (limited to 'tools/gritsettings')
| -rw-r--r-- | tools/gritsettings/resource_ids | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/gritsettings/resource_ids b/tools/gritsettings/resource_ids index 9e64b16..988008c 100644 --- a/tools/gritsettings/resource_ids +++ b/tools/gritsettings/resource_ids @@ -241,7 +241,7 @@ "messages": [30010], }, "components/resources/components_resources.grd": { - "includes": [30260], + "includes": [30270], }, "components/resources/components_scaled_resources.grd": { "structures": [30310], |