summaryrefslogtreecommitdiffstats
path: root/tools/lsan
diff options
context:
space:
mode:
authorearthdok@chromium.org <earthdok@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-01 18:58:41 +0000
committerearthdok@chromium.org <earthdok@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-01 18:58:41 +0000
commit7faab21165a788e8a44d53203e68eaf709d728b1 (patch)
tree5642686a94fddabc0f04f5172a3063d0ece052d3 /tools/lsan
parent60fe1d9dc1f4ae1f265707622f61c2ea5d559871 (diff)
downloadchromium_src-7faab21165a788e8a44d53203e68eaf709d728b1.zip
chromium_src-7faab21165a788e8a44d53203e68eaf709d728b1.tar.gz
chromium_src-7faab21165a788e8a44d53203e68eaf709d728b1.tar.bz2
Prune some LeakSanitizer suppressions.
Remove some suppressions which no longer match. Among them a bunch of suppressions related to Blink bindings, which I assume is related to Oilpan deployment. Also, improve a comment in the suppressions file. BUG=99304, 67378, 189170, 328552, 317965 TBR=glider@chromium.org Review URL: https://codereview.chromium.org/184103009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254378 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/lsan')
-rw-r--r--tools/lsan/suppressions.txt35
1 files changed, 6 insertions, 29 deletions
diff --git a/tools/lsan/suppressions.txt b/tools/lsan/suppressions.txt
index 7ce8add..43b9d87 100644
--- a/tools/lsan/suppressions.txt
+++ b/tools/lsan/suppressions.txt
@@ -10,15 +10,6 @@ leak:libfontconfig
# TODO(earthdok): Annotate.
leak:WTF::BitVector::resizeOutOfLine
-# V8 leak, expect 1024 bytes leaked per process. http://crbug.com/99304
-leak:v8::internal::V8::Initialize
-
-# V8 GC issues in ProxyResolver tests, probably harmless. http://crbug.com/67378
-leak:net::ProxyResolverV8::SetPacScript
-leak:net::(anonymous namespace)::ProxyResolverV8WithMockBindings::SetPacScriptFromDisk
-leak:net::(anonymous namespace)::InitResolver
-leak:net::ProxyResolverScriptData::FromUTF8
-
# A small string is leaked here (57 bytes per process). http://crbug.com/46571#c9
leak:WebCore::V8GCController::collectGarbage
@@ -49,9 +40,6 @@ leak:libnss3
leak:libplds4
leak:libnssckbi
-# Skia leaks. http://crbug.com/189170
-leak:FontConfigTypeface::LegacyCreateTypeface
-
# Skia leaks GrGpuGL::ProgramCache::Entry. http://crbug.com/262934
leak:GrGpuGL::flushGraphicsState
@@ -66,23 +54,15 @@ leak:v8::internal::Genesis::Genesis
# Those should only fire in (browser)tests. If you see one of them in Chrome,
# then it's a real leak.
# http://crbug.com/328552
-leak:extensions::ObjectBackedNativeHandler::RouteFunction
-leak:toString<WTF::AtomicString>
-leak:WebCore::StringCache::createStringAndInsertIntoCache
leak:WebCore::V8WindowShell::initializeIfNeeded
-leak:WebCore::V8MouseEvent::constructorCallback
leak:WebCore::*::*GetterCallback
-leak:WebCore::*::*SetterCallback
-leak:WebCore::*::errorMethodCallback
-leak:WebCore::v8StringToWebCoreString
-leak:WTF::StringImpl::createUninitialized
-leak:ResourceBundleSourceMap::GetSource
-leak:WebCore::ScriptState::forContext
-leak:TranslateScriptBrowserTest::ExecuteScript
#### Actual bugs in Chromium code ####
-# PLEASE DO NOT ADD NEW SUPPRESSIONS TO THIS SECTION. Instead, commits that
-# introduce memory leaks should be reverted.
+# PLEASE DO NOT ADD SUPPRESSIONS FOR NEW LEAKS.
+# Instead, commits that introduce memory leaks should be reverted. Suppressing
+# the leak is acceptable in some cases when reverting is impossible, i.e. when
+# enabling leak detection for the first time for a test target with pre-existing
+# leaks.
# Small test-only leak in ppapi_unittests. http://crbug.com/258113
leak:ppapi::proxy::PPP_Instance_Private_ProxyTest_PPPInstancePrivate_Test
@@ -91,9 +71,6 @@ leak:ppapi::proxy::PPP_Instance_Private_ProxyTest_PPPInstancePrivate_Test
leak:gpu::gles2::GLES2DecoderImpl::DoBindRenderbuffer
leak:gpu::gles2::GLES2DecoderImpl::DoRenderbufferStorage
-# Leak in cc_unittests. http://crbug.com/317965
-leak:cc::ThreadProxy::ReadyToFinalizeTextureUpdates
-
# Leak in unit_tests and browser_tests. http://crbug.com/309468
leak:TranslateBubbleView::CreateViewBeforeTranslate()
@@ -113,4 +90,4 @@ leak:base::EnsureProcessTerminated
# http://crbug.com/322671
leak:content::SpeechRecognitionBrowserTest::SetUpOnMainThread
-# PLEASE DO NOT ADD NEW SUPPRESSIONS HERE. See the comment above.
+# PLEASE READ ABOVE BEFORE ADDING NEW SUPPRESSIONS.