diff options
| author | felt@chromium.org <felt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-14 17:33:06 +0000 |
|---|---|---|
| committer | felt@chromium.org <felt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-14 17:33:06 +0000 |
| commit | 6cfd2a105628d13f0706fcd0cb70a1f77f87d24e (patch) | |
| tree | cc03c532d3ae0f30147d55ffb26ad8ca4c00ef3a /tools/metrics/actions | |
| parent | 78228a363ca168386fe2b5c8601a6dd5ce865d3e (diff) | |
| download | chromium_src-6cfd2a105628d13f0706fcd0cb70a1f77f87d24e.zip chromium_src-6cfd2a105628d13f0706fcd0cb70a1f77f87d24e.tar.gz chromium_src-6cfd2a105628d13f0706fcd0cb70a1f77f87d24e.tar.bz2 | |
Adds the ability to opt out of Safe Browsing download feedback from settings.
Notes:
- The download feedback pref is an enum with a ternary (not binary) value. As a result, need to set up a special handler to toggle the checkbox appropriately.
- Moved DownloadReportingStatus enum from DownloadFeedbackDialogView into DownloadFeedbackService. This lets BrowserOptionsHandler use the enum.
-------
How to test (currently Win & CrOS only):
A
1. Go to chrome://settings on a clean build; search for 'Privacy'
2. Verify that "Send suspicious downloaded files to Google" is not checked
B
1. Visit http://testsafebrowsing.appspot.com/, click on #5
2. Click discard in the download item
3. Click 'No thanks' in the dialog
4. Go to chrome://settings; search for 'Privacy'
5. Verify that "Send suspicious downloaded files to Google" is not checked
C
1. Clear your user preferences (e.g., delete the Preferences file in your user data directory)
2. Visit http://testsafebrowsing.appspot.com/, click on #5
3. Click discard in the download item
4. Click 'OK' in the dialog
5. Go to chrome://settings; search for 'Privacy'
6. Verify that "Send suspicious downloaded files to Google" is checked
-----------
BUG=312533
Review URL: https://codereview.chromium.org/153353006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251363 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/metrics/actions')
| -rw-r--r-- | tools/metrics/actions/chromeactions.txt | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/metrics/actions/chromeactions.txt b/tools/metrics/actions/chromeactions.txt index 3755b92..1de9216 100644 --- a/tools/metrics/actions/chromeactions.txt +++ b/tools/metrics/actions/chromeactions.txt @@ -1492,6 +1492,8 @@ 0x6b2fbab68d97bb5b Options_SSL3_Enable 0x08e75d386343cc27 Options_SafeBrowsingCheckbox_Disable 0xc951b246a33514ac Options_SafeBrowsingCheckbox_Enable +0x96ebcd98112d0930 Options_SafeBrowsingDownloadFeedbackCheckbox_Disable +0xab0f183ebf8995bb Options_SafeBrowsingDownloadFeedbackCheckbox_Enable 0x7653dc09eac4e2bf Options_SearchEngineChanged 0x47fd936f55f6abd4 Options_SensitivitySlider_Changed 0xb6e98e1635e14c7d Options_SetAsDefaultBrowser |