diff options
author | davidben <davidben@chromium.org> | 2016-03-11 17:40:34 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-12 01:42:03 +0000 |
commit | 6e50b9f54970b1527162fba5611b8d1b41a9d9ba (patch) | |
tree | 467c1a3b9f817a520ca0c5b62355213fe45edd7c /tools/metrics | |
parent | 51328f113889a8562fd9ea3fd5f92305337db6d2 (diff) | |
download | chromium_src-6e50b9f54970b1527162fba5611b8d1b41a9d9ba.zip chromium_src-6e50b9f54970b1527162fba5611b8d1b41a9d9ba.tar.gz chromium_src-6e50b9f54970b1527162fba5611b8d1b41a9d9ba.tar.bz2 |
Add histograms to track down the cause of ERR_SSL_PROTOCOL_ERROR.
These histograms will be removed when the bug is resolved (or really as soon
as we get data back, so hopefully Monday...). Notably, they record BoringSSL
error reasons which are *not* stable.
The intent of these histograms is to:
- Determine what BoringSSL error is triggering these.
- Based on magnitudes, confirm this is coming from Read/Write and not Connect.
- See if there is a correlation with some cipher suite by comparing the
distribution with the normal cipher suite distribution.
BUG=593963
Review URL: https://codereview.chromium.org/1786593003
Cr-Commit-Position: refs/heads/master@{#380827}
Diffstat (limited to 'tools/metrics')
-rw-r--r-- | tools/metrics/histograms/histograms.xml | 34 |
1 files changed, 34 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 1cd4a80..bbee64d 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -28530,6 +28530,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. <summary>Time to complete a speculative certificate verification.</summary> </histogram> +<histogram name="Net.SSLProtocolErrorCipher" enum="SSLCipherSuite"> + <owner>davidben@chromium.org</owner> + <summary> + The cipher suite used when the corresponding operation on an SSLClientSocket + fails with ERR_SSL_PROTOCOL_ERROR. This histogram will be removed when + https://crbug.com/593963 is resolved. + </summary> +</histogram> + +<histogram name="Net.SSLProtocolErrorReason" enum="BoringSSLReasonCode"> + <owner>davidben@chromium.org</owner> + <summary> + The internal, version-specific BoringSSL error reason reported when the + corresponding operation on an SSLClientSocket fails with + ERR_SSL_PROTOCOL_ERROR. This histogram will be removed when + https://crbug.com/593963 is resolved. + </summary> +</histogram> + <histogram name="Net.SSLProtocolNegotiation" enum="SSLProtocolNegotiation"> <owner>bnc@chromium.org</owner> <summary> @@ -60660,6 +60679,13 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. <int value="1" label="Wiped out"/> </enum> +<enum name="BoringSSLReasonCode" type="int"> + <details> + See include/openssl/ssl.h at the corresponding BoringSSL revision for the + corresponding values. + </details> +</enum> + <enum name="BrokenAlternateProtocolLocation" type="int"> <int value="0" label="HTTP_STREAM_FACTORY_IMPL_JOB"/> <int value="1" label="QUIC_STREAM_FACTORY"/> @@ -89404,6 +89430,14 @@ To add a new entry, add it with any value and run test to compute valid value. <affected-histogram name="SimpleCache.SyncOpenResult"/> </histogram_suffixes> +<histogram_suffixes name="SocketOperation" separator="."> + <affected-histogram name="Net.SSLProtocolErrorCipher"/> + <affected-histogram name="Net.SSLProtocolErrorReason"/> + <suffix name="Connect"/> + <suffix name="Read"/> + <suffix name="Write"/> +</histogram_suffixes> + <histogram_suffixes name="SocketType"> <obsolete> Deprecated as of 03/2015. |