summaryrefslogtreecommitdiffstats
path: root/tools/metrics
diff options
context:
space:
mode:
authornparker <nparker@chromium.org>2016-03-25 09:15:07 -0700
committerCommit bot <commit-bot@chromium.org>2016-03-25 16:16:36 +0000
commit74ab4f95a557f6cfb425555a0c7021e80d9319dc (patch)
tree3d0c6e1f97695636fb43f6b63d78c609ac177359 /tools/metrics
parentc0164a8eff21b43ad24d8488424c0ad15d1211c3 (diff)
downloadchromium_src-74ab4f95a557f6cfb425555a0c7021e80d9319dc.zip
chromium_src-74ab4f95a557f6cfb425555a0c7021e80d9319dc.tar.gz
chromium_src-74ab4f95a557f6cfb425555a0c7021e80d9319dc.tar.bz2
Report and parse .img, .iso, and .smi as DMGs when downloading
These files are all opened by Disk Utility. 70% of this patch was written by research@nightwatchcybersecurity.com BUG=596354 Review URL: https://codereview.chromium.org/1827303002 Cr-Commit-Position: refs/heads/master@{#383277}
Diffstat (limited to 'tools/metrics')
-rw-r--r--tools/metrics/histograms/histograms.xml44
1 files changed, 44 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 50a4aef..f39dc79 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43782,16 +43782,49 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileFailureByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types that failed to be successfully analyzed by the
+ SafeBrowsing download service.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DmgFileHasExecutable" enum="Boolean">
<owner>rsesek@chromium.org</owner>
+ <obsolete>
+ Replaced by SBClientDownload.DmgFileHas[No]ExecutableByType in M51.
+ </obsolete>
<summary>
For each DMG file analyzed by the SafeBrowsing download service, records if
the DMG contained an executable file.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileHasExecutableByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types which were analyzed by the SafeBrowsing
+ download service that contained an executable file.
+ </summary>
+</histogram>
+
+<histogram name="SBClientDownload.DmgFileHasNoExecutableByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types which were analyzed by the SafeBrowsing
+ download service that did NOT contain an executable file.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DmgFileSuccess" enum="BooleanSuccess">
<owner>rsesek@chromium.org</owner>
+ <obsolete>
+ Replaced by SBClientDownload.DmgFile{Success,Failure}ByType in M51.
+ </obsolete>
<summary>
For each DMG file analyzed by the SafeBrowsing download service, records
true if the analysis was successful, or false if there was an error
@@ -43799,6 +43832,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="SBClientDownload.DmgFileSuccessByType"
+ enum="SBClientDownloadExtensions">
+ <owner>nparker@chromium.org</owner>
+ <summary>
+ Counts of DMG-like file types that were successfully analyzed by the
+ SafeBrowsing download service.
+ </summary>
+</histogram>
+
<histogram name="SBClientDownload.DownloadExtensions"
enum="SBClientDownloadExtensions">
<owner>mattm@chromium.org</owner>
@@ -80352,6 +80394,8 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="244" label="RTF"/>
<int value="245" label="VHDX"/>
<int value="246" label="SEARCH_MS"/>
+ <int value="247" label="IMG"/>
+ <int value="248" label="SMI"/>
</enum>
<enum name="SBClientDownloadIsSignedBinary" type="int">