summaryrefslogtreecommitdiffstats
path: root/tools/metrics
diff options
context:
space:
mode:
authorrockot <rockot@chromium.org>2016-03-10 22:17:34 -0800
committerCommit bot <commit-bot@chromium.org>2016-03-11 06:20:10 +0000
commitc7b3190c0ecd5b88688aa5e55d3085f0fbd40e11 (patch)
tree085eeb55738f19e6970d9cfad37f4df31d0199f0 /tools/metrics
parent71a42d8ea237f636bc39b6048e7a228ee260e9f9 (diff)
downloadchromium_src-c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11.zip
chromium_src-c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11.tar.gz
chromium_src-c7b3190c0ecd5b88688aa5e55d3085f0fbd40e11.tar.bz2
Instrument MojoShellConnectionImpl::BindToMessagePipe
This adds a histogram to measure the duration of calls to MojoShellConnectionImpl::BindToMessagePipe in child processes. The new histogram replaces a useless one which was recently added to measure uninteresting calls to MojoShellConnection::Create() in renderers. BindToMessagePipe cost should be significantly reduced in a follow-up CL, but it will still need to do some non-trivial amount of work. This metric will help us detect if it remains problematic or regresses. BUG=591742 R=ben@chromium.org Review URL: https://codereview.chromium.org/1782133002 Cr-Commit-Position: refs/heads/master@{#380555}
Diffstat (limited to 'tools/metrics')
-rw-r--r--tools/metrics/histograms/histograms.xml6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b3254d0..0991368 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -22047,12 +22047,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Mojo.Shell.RenderProcessInitializationTime" units="ms">
+<histogram name="Mojo.Shell.ChildConnectionTime" units="ms">
<owner>rockot@chromium.org</owner>
<summary>
- Measures the time it takes for a new render process to receive an
+ Measures the time it takes for a new child process to receive an
initialization request from the Mojo shell. This is precisely the duration
- of the MojoShellConnectionImpl::Create() call in RendererMain.
+ of the MojoShellConnectionImpl::BindToMessagePipe() call in ChildThreadImpl.
</summary>
</histogram>