diff options
| author | nednguyen <nednguyen@google.com> | 2015-10-27 13:40:36 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-27 20:41:11 +0000 |
| commit | 48c1471f1f503246dd66753a4c7588d77282d2df (patch) | |
| tree | 9e20269fed1d2dfd3424dfb6d1246c671087292d /tools/perf/core | |
| parent | 84f6037e951c21a3b00bd3ddd034f258da6839b5 (diff) | |
| download | chromium_src-48c1471f1f503246dd66753a4c7588d77282d2df.zip chromium_src-48c1471f1f503246dd66753a4c7588d77282d2df.tar.gz chromium_src-48c1471f1f503246dd66753a4c7588d77282d2df.tar.bz2 | |
[Telemetry] Enable option for telemetry to take screenshot of failed pages.
Screenshot of failed pages are added to telemetry's results profiling files, and
hence will be uploaded for all perf benchmarks.
BUG=369490
TEST=unittest + modifying facebook page locally to raise an exception:
$ ./tools/perf/run_benchmark --browser=system smoothness.top_25_smooth --story-filter=Facebook --upload-results[ RUN ] Facebook
/usr/local/google/home/nednguyen/projects/chromium/src/tools/telemetry/telemetry/page/shared_page_state.py:236: UserWarning: Function RestartBrowserBeforeEachPage is deprecated. It will no longer be supported on October 21, 2015. Please remove it or switch to an alternative before that time. Please use benchmark.ShouldTearDownStateAfterEachStoryRun() in the future.
if self._test.RestartBrowserBeforeEachPage():
Traceback (most recent call last):
File "/usr/local/google/home/nednguyen/projects/chromium/src/tools/telemetry/telemetry/internal/story_runner.py", line 83, in _RunStoryAndProcessErrorIfNeeded
state.RunStory(results)
File "/usr/local/google/home/nednguyen/projects/chromium/src/tools/telemetry/telemetry/page/shared_page_state.py", line 320, in RunStory
self._current_page.Run(self)
File "/usr/local/google/home/nednguyen/projects/chromium/src/tools/telemetry/telemetry/page/__init__.py", line 84, in Run
shared_state.page_test.RunNavigateSteps(self, current_tab)
File "/usr/local/google/home/nednguyen/projects/chromium/src/tools/telemetry/telemetry/page/page_test.py", line 187, in RunNavigateSteps
page.RunNavigateSteps(action_runner)
File "/usr/local/google/home/nednguyen/projects/chromium/src/tools/perf/page_sets/top_pages.py", line 200, in RunNavigateSteps
raise Exception
Exception
[ FAILED ] Facebook (4134 ms)
Traceback (most recent call last):
RunBenchmark at tools/telemetry/telemetry/internal/story_runner.py:302
benchmark.ShouldTearDownStateAfterEachStoryRun())
Run at tools/telemetry/telemetry/internal/story_runner.py:222
_RunStoryAndProcessErrorIfNeeded(story, results, state, test)
_RunStoryAndProcessErrorIfNeeded at tools/telemetry/telemetry/internal/story_runner.py:83
state.RunStory(results)
RunStory at tools/telemetry/telemetry/page/shared_page_state.py:320
self._current_page.Run(self)
Run at tools/telemetry/telemetry/page/__init__.py:84
shared_state.page_test.RunNavigateSteps(self, current_tab)
RunNavigateSteps at tools/telemetry/telemetry/page/page_test.py:187
page.RunNavigateSteps(action_runner)
RunNavigateSteps at tools/perf/page_sets/top_pages.py:200
raise Exception
Exception
Locals:
action_runner : <telemetry.page.action_runner.ActionRunner object at 0x7fbaeef63c50>
View generated profiler files online at https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_0-2015-10-26_15-45-4084089.png for page Facebook
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] Facebook
1 FAILED TEST
Pages: []
RESULT telemetry_page_measurement_results: num_failed= 1 count
RESULT telemetry_page_measurement_results: num_errored= 0 count
View online at http://storage.googleapis.com/chromium-telemetry/html-results/results-2015-10-26_15-45-42
View result at file:///usr/local/google/home/nednguyen/projects/chromium/src/tools/perf/results.html
(WARNING) 2015-10-26 15:45:43,718 webpagereplay.StopServer:226 Attempting to stop WPR server that is not running.
Review URL: https://codereview.chromium.org/1425693002
Cr-Commit-Position: refs/heads/master@{#356388}
Diffstat (limited to 'tools/perf/core')
| -rw-r--r-- | tools/perf/core/perf_benchmark.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/perf/core/perf_benchmark.py b/tools/perf/core/perf_benchmark.py index fa29bf9..3fb686f 100644 --- a/tools/perf/core/perf_benchmark.py +++ b/tools/perf/core/perf_benchmark.py @@ -28,6 +28,10 @@ class PerfBenchmark(benchmark.Benchmark): # Subclass of PerfBenchmark should override SetExtraBrowserOptions to add # more browser options rather than overriding CustomizeBrowserOptions. super(PerfBenchmark, self).CustomizeBrowserOptions(options) + + # Enable taking screen shot on failed pages for all perf benchmarks. + options.take_screenshot_for_failed_page = True + # The current field trial config is used for an older build in the case of # reference. This is a problem because we are then subjecting older builds # to newer configurations that may crash. To work around this problem, |