diff options
author | erikchen <erikchen@chromium.org> | 2015-03-04 18:07:47 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-05 02:08:51 +0000 |
commit | 910d6e733bac30f15f76054eb101a81987f8c675 (patch) | |
tree | 07d492db264eb0938c91d39dabbf8f140a0e45be /tools/perf/profile_creators | |
parent | 4bb1b1ca394563b0f526d484b23b4e4d59de04af (diff) | |
download | chromium_src-910d6e733bac30f15f76054eb101a81987f8c675.zip chromium_src-910d6e733bac30f15f76054eb101a81987f8c675.tar.gz chromium_src-910d6e733bac30f15f76054eb101a81987f8c675.tar.bz2 |
Telemetry: Add more details to inspector_backend exceptions.
Previously, inspector_backend would always throw a
DevtoolsTargetCrashException. Now, it throws either a
DevtoolsTargetCrashException or a TimeoutException. The CL also adds the
debugger_url to the exception as further debugging information.
There were exactly 2 files that tried to catch a DevtoolsTargetCrashException.
I changed fast_navigation_profile_extender to catch Error instead. I will be
improving this class in the future to have better exception handling.
chrome_proxy_measurements caught a DevtoolsTargetCrashException, but its
behavior is better suited by catching a TimeoutException.
BUG=460625
Review URL: https://codereview.chromium.org/959423003
Cr-Commit-Position: refs/heads/master@{#319193}
Diffstat (limited to 'tools/perf/profile_creators')
-rw-r--r-- | tools/perf/profile_creators/fast_navigation_profile_extender.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/perf/profile_creators/fast_navigation_profile_extender.py b/tools/perf/profile_creators/fast_navigation_profile_extender.py index e490403..abcc8eb 100644 --- a/tools/perf/profile_creators/fast_navigation_profile_extender.py +++ b/tools/perf/profile_creators/fast_navigation_profile_extender.py @@ -161,7 +161,7 @@ class FastNavigationProfileExtender(object): """Retrives the URL of the tab.""" try: return tab.EvaluateJavaScript('document.URL', timeout) - except (exceptions.DevtoolsTargetCrashException, + except (exceptions.Error, devtools_http.DevToolsClientConnectionError, devtools_http.DevToolsClientUrlError): return None @@ -204,7 +204,7 @@ class FastNavigationProfileExtender(object): try: tab.Navigate(url, None, timeout_in_seconds) - except (exceptions.DevtoolsTargetCrashException, + except (exceptions.Error, devtools_http.DevToolsClientConnectionError, devtools_http.DevToolsClientUrlError): # We expect a time out. It's possible for other problems to arise, but @@ -242,7 +242,7 @@ class FastNavigationProfileExtender(object): except exceptions.TimeoutException: # Ignore time outs. pass - except (exceptions.DevtoolsTargetCrashException, + except (exceptions.Error, devtools_http.DevToolsClientConnectionError, devtools_http.DevToolsClientUrlError): # If any error occurs, remove the tab. it's probably in an |