diff options
| author | simonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-20 06:20:07 +0000 |
|---|---|---|
| committer | simonhatch@chromium.org <simonhatch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-20 06:20:07 +0000 |
| commit | e0e4381f7d90907651c0ab891c758ef423d559f9 (patch) | |
| tree | 7f6fa46205467793765fb25ddae421ad81693969 /tools/prepare-bisect-perf-regression.py | |
| parent | 3d40ab040113f38d29fd17442d787558dcd82d40 (diff) | |
| download | chromium_src-e0e4381f7d90907651c0ab891c758ef423d559f9.zip chromium_src-e0e4381f7d90907651c0ab891c758ef423d559f9.tar.gz chromium_src-e0e4381f7d90907651c0ab891c758ef423d559f9.tar.bz2 | |
The perf dashboard scrapes the "results" step from the bisect in order to comment on bugs. At the moment, the script only produces a "Results" step on success. On failure, it will either output a "Results - Bisect Failed" or in a lot of cases just print an error to stdout. Refactored error handling code to raise exceptions, which can be caught at the end of main and we can ensure that a "Results" step is written.
BUG=
Review URL: https://codereview.chromium.org/29033004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229679 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/prepare-bisect-perf-regression.py')
| -rwxr-xr-x | tools/prepare-bisect-perf-regression.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/tools/prepare-bisect-perf-regression.py b/tools/prepare-bisect-perf-regression.py index c12edbd..a07fcff 100755 --- a/tools/prepare-bisect-perf-regression.py +++ b/tools/prepare-bisect-perf-regression.py @@ -58,9 +58,11 @@ def main(): return 1 if not bisect_utils.CheckIfBisectDepotExists(opts): - return bisect_utils.CreateBisectDirectoryAndSetupDepot( - opts, - bisect_utils.DEFAULT_GCLIENT_CUSTOM_DEPS) + try: + bisect_utils.CreateBisectDirectoryAndSetupDepot(opts, + bisect_utils.DEFAULT_GCLIENT_CUSTOM_DEPS) + except RuntimeError: + return 1 return 0 |