diff options
author | prasadv <prasadv@chromium.org> | 2015-09-01 16:56:23 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-01 23:56:57 +0000 |
commit | b9a8751fe3056400f7f524a9e7538f9493f51298 (patch) | |
tree | a8c91ce6d57f8c833bd02ce6d4b844fa72abf0c0 /tools/run-bisect-perf-regression.py | |
parent | 4c3ed3e49e5f4e32f77037b4e5ace914cdee6143 (diff) | |
download | chromium_src-b9a8751fe3056400f7f524a9e7538f9493f51298.zip chromium_src-b9a8751fe3056400f7f524a9e7538f9493f51298.tar.gz chromium_src-b9a8751fe3056400f7f524a9e7538f9493f51298.tar.bz2 |
Remove support for ChromeShell apk.
BUG=526844
Review URL: https://codereview.chromium.org/1305223005
Cr-Commit-Position: refs/heads/master@{#346793}
Diffstat (limited to 'tools/run-bisect-perf-regression.py')
-rwxr-xr-x | tools/run-bisect-perf-regression.py | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py index 27c0c77..7641617 100755 --- a/tools/run-bisect-perf-regression.py +++ b/tools/run-bisect-perf-regression.py @@ -228,10 +228,7 @@ def _CreateBisectOptionsFromConfig(config): raise RuntimeError('CrOS build selected, but BISECT_CROS_IP or' 'BISECT_CROS_BOARD undefined.') elif 'android' in config['command']: - # TODO (prasadv): Remove android-chrome-shell check once we confirm that - # there are no pending bisect jobs with this in command. - if any(item in config['command'] - for item in ['android-chrome-shell', 'android-chromium']): + if 'android-chromium' in config['command']: opts_dict['target_platform'] = 'android' elif 'android-chrome' in config['command']: opts_dict['target_platform'] = 'android-chrome' @@ -531,10 +528,7 @@ def _RunBisectionScript( # Possibly set the target platform name based on the browser name in a # Telemetry command. - # TODO (prasadv): Remove android-chrome-shell check once we confirm there are - # no pending bisect jobs with this in command. - if any(item in config['command'] - for item in ['android-chrome-shell', 'android-chromium']): + if 'android-chromium' in config['command']: cmd.extend(['--target_platform', 'android']) elif 'android-chrome' in config['command']: cmd.extend(['--target_platform', 'android-chrome']) @@ -627,10 +621,7 @@ def _GetConfigBasedOnPlatform(config, bot_name, test_name): opts_dict['use_goma'] = config['use_goma'] if 'goma_dir' in config: opts_dict['goma_dir'] = config['goma_dir'] - # TODO (prasadv): Remove android-chrome-shell check once we confirm there are - # no pending bisect jobs with this in command. - if any(item in opts_dict['command'] - for item in ['android-chrome-shell', 'android-chromium']): + if 'android-chromium' in opts_dict['command']: opts_dict['target_platform'] = 'android' return bisect_perf_regression.BisectOptions.FromDict(opts_dict) |