diff options
author | qyearsley <qyearsley@chromium.org> | 2015-01-27 16:27:02 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-01-28 00:28:20 +0000 |
commit | bd0f02085daa509d9d56a9c313976e814759eb82 (patch) | |
tree | 69534110b599c9320318d0723386a06a213172f6 /tools/run-bisect-perf-regression.py | |
parent | db0e8ddf9c524249b40504e5de3ec36076aa6ce0 (diff) | |
download | chromium_src-bd0f02085daa509d9d56a9c313976e814759eb82.zip chromium_src-bd0f02085daa509d9d56a9c313976e814759eb82.tar.gz chromium_src-bd0f02085daa509d9d56a9c313976e814759eb82.tar.bz2 |
Use builder_type when requesting/fetching builds, and add support for full linux builds.
Changes in this CL:
- In request_build.py, add a URL for linux try bot.
- Add sample config for functional bisect.
- Make perf-related config parameters optional.
- Use builder type when starting build try jobs, and when fetching builds.
A few other changes:
- Update bisect_perf_regression.py file docstring.
- Rename _BuilderTryjob to _StartBuilderTryJob and refactor.
- Remove unused code in request_build.py.
Proposed follow-up:
- Move functions related to builder to be methods of one class, so that the builder-specific info/logic (e.g. builder bot and archive location) is in one place.
BUG=
Review URL: https://codereview.chromium.org/806943007
Cr-Commit-Position: refs/heads/master@{#313415}
Diffstat (limited to 'tools/run-bisect-perf-regression.py')
-rwxr-xr-x | tools/run-bisect-perf-regression.py | 23 |
1 files changed, 5 insertions, 18 deletions
diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py index f2eff2a..ac6f14e 100755 --- a/tools/run-bisect-perf-regression.py +++ b/tools/run-bisect-perf-regression.py @@ -148,13 +148,7 @@ def _ValidatePerfConfigFile(config_contents): Returns: True if valid. """ - required_parameters = [ - 'command', - 'repeat_count', - 'truncate_percent', - 'max_time_minutes', - ] - return _ValidateConfigFile(config_contents, required_parameters) + return _ValidateConfigFile(config_contents, required_parameters=['command']) def _ValidateBisectConfigFile(config_contents): @@ -169,16 +163,9 @@ def _ValidateBisectConfigFile(config_contents): Returns: True if valid. """ - required_params = [ - 'command', - 'good_revision', - 'bad_revision', - 'metric', - 'repeat_count', - 'truncate_percent', - 'max_time_minutes', - ] - return _ValidateConfigFile(config_contents, required_params) + return _ValidateConfigFile( + config_contents, + required_parameters=['command', 'good_revision', 'bad_revision']) def _OutputFailedResults(text_to_print): @@ -498,13 +485,13 @@ def _RunBisectionScript( '--command', config['command'], '--good_revision', config['good_revision'], '--bad_revision', config['bad_revision'], - '--metric', config['metric'], '--working_directory', working_directory, '--output_buildbot_annotations' ] # Add flags for any optional config parameters if given in the config. options = [ + ('metric', '--metric'), ('repeat_count', '--repeat_test_count'), ('truncate_percent', '--truncate_percent'), ('max_time_minutes', '--max_time_minutes'), |