diff options
| author | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 15:34:47 +0000 |
|---|---|---|
| committer | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 15:34:47 +0000 |
| commit | 3b06c181341b9abac14f3c9e55271c3ae44d275b (patch) | |
| tree | 81124b098d15b49af91f7ea185713400e4dc06b7 /tools/telemetry | |
| parent | d0bd2d4181f1d8ab2c349ab1ce64d5fc464da320 (diff) | |
| download | chromium_src-3b06c181341b9abac14f3c9e55271c3ae44d275b.zip chromium_src-3b06c181341b9abac14f3c9e55271c3ae44d275b.tar.gz chromium_src-3b06c181341b9abac14f3c9e55271c3ae44d275b.tar.bz2 | |
[Telemetry] Don't restart the browser when the WPR archive path changes.
Simply restart WPR using the same port it was on before. The browser will still
be set up to point to that port.
I think we originally restarted the browser because we used to not explicitly
pass the ports to use to WPR. Now that those are stored in browser_backend,
they can stay stable across WPR restarts.
BUG=None
TEST=tools/perf/run_measurement --browser=android-content-shell page_cycler tools/perf/page_sets/top_25.json --page-filter="youtube|plus" --pageset-repeat=1 -v
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/15917016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202877 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/telemetry')
| -rw-r--r-- | tools/telemetry/telemetry/page/page_runner.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py index edf7be8..2cad4a3 100644 --- a/tools/telemetry/telemetry/page/page_runner.py +++ b/tools/telemetry/telemetry/page/page_runner.py @@ -105,9 +105,8 @@ class PageRunner(object): possible_browser.options.wpr_mode = wpr_modes.WPR_REPLAY else: possible_browser.options.wpr_mode = wpr_modes.WPR_OFF - if last_archive_path != page.archive_path: - state.Close() - state = _RunState() + if last_archive_path != page.archive_path and state.browser: + state.browser.SetReplayArchivePath(page.archive_path) last_archive_path = page.archive_path if (test.discard_first_result and not self.has_called_will_run_page_set): |