diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 21:05:16 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 21:05:16 +0000 |
| commit | 1848125e97d7516db12feb01b9d19447da5ce99b (patch) | |
| tree | 5eaa295c6f62ffdd40150c8b50a519866d8aa8bd /tools/valgrind/tsan | |
| parent | 4ef45eaf7d802ace67fca9652aa1f9f5998cbc74 (diff) | |
| download | chromium_src-1848125e97d7516db12feb01b9d19447da5ce99b.zip chromium_src-1848125e97d7516db12feb01b9d19447da5ce99b.tar.gz chromium_src-1848125e97d7516db12feb01b9d19447da5ce99b.tar.bz2 | |
Move tsan suppression for SequencedWorkerPool to benign section
Add unit test to consistently reproduce (benign) histogram race.
BUG=115987
TEST=
Review URL: https://chromiumcodereview.appspot.com/9522009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124250 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/tsan')
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 26 |
1 files changed, 18 insertions, 8 deletions
diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index 702f4e2..267c520 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -378,6 +378,23 @@ fun:base::*Histogram::FactoryGet } +{ + bug_115987a [benign races in Histogram in SequencedWorkerPool] + ThreadSanitizer:Race + ... + fun:base::Histogram::* + fun:base::SequencedWorkerPool::* +} + +# Histogram macros involve string comparison in debug mode. +{ + bug_115987b [benign races in Histogram in SequencedWorkerPool] + ThreadSanitizer:Race + ... + fun:std::operator== + fun:base::SequencedWorkerPool::* +} + # 3. Suppressions for real chromium bugs that are not yet fixed. ############################ # Real races in Chromium @@ -834,11 +851,4 @@ fun:AudioRendererHost::OnCreated fun:media::AudioOutputController::DoCreate } -{ - bug_115987 - ThreadSanitizer:Race - ... - fun:base::Histogram::Add - fun:base::SequencedWorkerPool::Inner::GetWork - fun:base::SequencedWorkerPool::Inner::ThreadLoop -} + |