summaryrefslogtreecommitdiffstats
path: root/tools/valgrind
diff options
context:
space:
mode:
authorhiroshige <hiroshige@chromium.org>2016-03-17 19:51:55 -0700
committerCommit bot <commit-bot@chromium.org>2016-03-18 02:53:14 +0000
commit22822feaf74bffc00dbe6db27cd3e36c1c568e11 (patch)
tree89a72857e8719820222cd35a4edee42b92b69be8 /tools/valgrind
parent468ca56ab508342df50c7ee16ac4f4e767a1614b (diff)
downloadchromium_src-22822feaf74bffc00dbe6db27cd3e36c1c568e11.zip
chromium_src-22822feaf74bffc00dbe6db27cd3e36c1c568e11.tar.gz
chromium_src-22822feaf74bffc00dbe6db27cd3e36c1c568e11.tar.bz2
Keep multipart responses in m_nonBlockingLoaders after first part loaded
For multipart responses, in the first ResourceLoader::didFinishLoadingOnePart(), (1) the ResourceLoader is moved from |m_loaders| to |m_nonBlockingLoaders| in ResourceFetcher::subresourceLoaderFinishedLoadingOnePart(), and (2) it is removed from |m_nonBlockingLoaders| in ResourceFetcher::willTerminateResourceLoader() called in didFinishLoading(). Therefore, if we call window.stop() just after multipart <img>'s onload event, we cannot stop loading of the multipart response because it is no longer in |m_loaders| nor |m_nonBlockingLoaders|. However, in the second didFinishLoadingOnePart(), (3) In subresourceLoaderFinishedLoadingOnePart(), the ResourceLoader is added again to |m_nonBlockingLoaders|, and (4) We don't call didFinishLoading()/willTerminateResourceLoader(). Therefore, we can stop loading of the image after that by window.stop(). This CL makes the ResourceLoader to be kept in |m_nonBlockingLoaders| after (1) and to be remove from |m_nonBlockingLoaders| when ResourceLoader::didFinishLoading() is called. This CL enables to stop loading of multipart responses at any time, and also enables https://codereview.chromium.org/1756953002/ to stop dispatching didFinishLoadingOnePart() for each part without affecting window.stop() behavior on multipart responses. BUG=570608 Review URL: https://codereview.chromium.org/1800333003 Cr-Commit-Position: refs/heads/master@{#381876}
Diffstat (limited to 'tools/valgrind')
0 files changed, 0 insertions, 0 deletions