diff options
| author | Robert Liao <robliao@chromium.org> | 2016-03-17 18:51:20 -0700 |
|---|---|---|
| committer | Robert Liao <robliao@chromium.org> | 2016-03-18 01:53:41 +0000 |
| commit | 38e785b06f3942adad154fddd1b83d8a0f299a5e (patch) | |
| tree | e63f9e8ee63e040835ef0d925342fa209db6965f /tools/valgrind | |
| parent | aecd33a68af96253f661e1f9af1c2cf690c78155 (diff) | |
| download | chromium_src-38e785b06f3942adad154fddd1b83d8a0f299a5e.zip chromium_src-38e785b06f3942adad154fddd1b83d8a0f299a5e.tar.gz chromium_src-38e785b06f3942adad154fddd1b83d8a0f299a5e.tar.bz2 | |
Make DrMemory update process reliable
The DrMemory update process only runs when it thinks that it needs to
but its heuristic is not accurate. A better thing to do is to always
update.
This change also adds setlocal so that environment variables don't
leak outside. This may also help with making this script more robust
in the future, once it has been in place for long enough for all
machines affected by the environment variable leakage to have rebooted.
BUG=595867
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/1807013004 .
Cr-Commit-Position: refs/heads/master@{#381870}
Diffstat (limited to 'tools/valgrind')
| -rwxr-xr-x | tools/valgrind/chrome_tests.bat | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/valgrind/chrome_tests.bat b/tools/valgrind/chrome_tests.bat index 138bec7..9fb9b2c 100755 --- a/tools/valgrind/chrome_tests.bat +++ b/tools/valgrind/chrome_tests.bat @@ -3,7 +3,8 @@ :: Use of this source code is governed by a BSD-style license that can be
:: found in the LICENSE file.
-:: TODO(timurrrr): batch files 'export' all the variables to the parent shell
+setlocal
+
set THISDIR=%~dp0
set TOOL_NAME="unknown"
@@ -32,7 +33,6 @@ echo "Unknown tool: `%TOOL_NAME%`! Only tsan and drmemory are supported right no exit /B 1
:SETUP_DRMEMORY
-if NOT "%DRMEMORY_COMMAND%"=="" GOTO :RUN_TESTS
:: Set up DRMEMORY_COMMAND to invoke Dr. Memory {{{1
set DRMEMORY_PATH=%THISDIR%..\..\third_party\drmemory
set DRMEMORY_SFX=%DRMEMORY_PATH%\drmemory-windows-sfx.exe
|