summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorrnk@chromium.org <rnk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-19 20:23:22 +0000
committerrnk@chromium.org <rnk@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-01-19 20:23:22 +0000
commit58026e262a8932be5f0ebd75d4744232f6327e2d (patch)
tree4cde9115b97c33985c64ea60e91b1475c1f733d3 /tools
parent51411e395569ea64f9a2529fc3eff26a2d9c7f39 (diff)
downloadchromium_src-58026e262a8932be5f0ebd75d4744232f6327e2d.zip
chromium_src-58026e262a8932be5f0ebd75d4744232f6327e2d.tar.gz
chromium_src-58026e262a8932be5f0ebd75d4744232f6327e2d.tar.bz2
Exclude JingleSessionTest.TestMultistepAuthTcpChannel from drmemory.
This test fails locally for me when run under DrMemory. On the bots, it passes but generates uninit reports. JingleSessionTest.TestTcpChannel is almost identical, and it is also excluded. TestMultistepAuthTcpChannel takes 260s on the bots, which is probably not a good use of bot resources, so I'm excluding it. Removing the suppressions I added for it. TBR=bruening@chromium.org BUG=110729 TEST=none Review URL: https://chromiumcodereview.appspot.com/9200008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118345 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/valgrind/drmemory/suppressions_full.txt34
-rw-r--r--tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt1
2 files changed, 2 insertions, 33 deletions
diff --git a/tools/valgrind/drmemory/suppressions_full.txt b/tools/valgrind/drmemory/suppressions_full.txt
index 6fd756c..3de3ce0 100644
--- a/tools/valgrind/drmemory/suppressions_full.txt
+++ b/tools/valgrind/drmemory/suppressions_full.txt
@@ -156,6 +156,7 @@ WINSPOOL.DRV!*
UNINITIALIZED READ
name=http://code.google.com/p/drmemory/issues/detail?id=48 a
system call NtContinue
+...
*!*SetThreadName
UNINITIALIZED READ
@@ -742,15 +743,6 @@ UNINITIALIZED READ
name=http://code.google.com/p/drmemory/issues/detail?id=493
USP10.dll!ScriptPositionSingleGlyph
-# Requires investigation, looks like syscall false pos.
-UNINITIALIZED READ
-name=http://code.google.com/p/drmemory/issues/detail?id=758
-system call NtContinue
-ntdll.dll!KiUserExceptionDispatcher
-KERNEL*.dll!*
-KERNEL*.dll!RaiseException
-*!talk_base::SetThreadName
-
###############################################################
# Benign issues in Chromium
@@ -930,27 +922,3 @@ name=http://crbug.com/110049
*!media::DoCrossfade<*>
*!media::Crossfade
*!media::AudioRendererAlgorithmBase::FillBuffer
-
-# Possible real Chromium issue in JingleSessionTest.TestMultistepAuthTcpChannel.
-# Need to make sure talk_base::FifoBuffer ctor is getting called. Doesn't look
-# like DrMemory unhandled syscall.
-UNINITIALIZED READ
-name=http://crbug.com/110729 a
-...
-*!jingle_glue::PseudoTcpAdapter::Write
-
-UNINITIALIZED READ
-name=http://crbug.com/110729 b
-...
-*!jingle_glue::PseudoTcpAdapter::Read
-
-UNINITIALIZED READ
-name=http://crbug.com/110729 c
-...
-*!jingle_glue::PseudoTcpAdapter::Core::HandleTcpClock
-
-# Not clear how this test is calling memcmp directly; bad stack?
-UNINITIALIZED READ
-name=http://crbug.com/110729 d
-drmemorylib.dll!replace_memcmp
-*!remoting::protocol::JingleSessionTest_TestMultistepAuthTcpChannel_Test::TestBody
diff --git a/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt b/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
index a21737c..7f01481 100644
--- a/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
+++ b/tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt
@@ -3,6 +3,7 @@
JingleSessionTest.Connect
JingleSessionTest.TestUdpChannel
JingleSessionTest.TestTcpChannel
+JingleSessionTest.TestMultistepAuthTcpChannel
JingleSessionTest.TestSpeed
# This test fails on an assertion, see http://crbug.com/57266