diff options
| author | wfh <wfh@chromium.org> | 2015-04-28 15:39:21 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-28 22:40:43 +0000 |
| commit | 22e2f4a23530e0b22c8f37dd91e4e803a0a6e355 (patch) | |
| tree | 700185ddc8d1eefa747915d72fc4a1fbfd20ef2c /tools | |
| parent | 7c64f265edca18adefe01d0a4e676a3f7b834bd1 (diff) | |
| download | chromium_src-22e2f4a23530e0b22c8f37dd91e4e803a0a6e355.zip chromium_src-22e2f4a23530e0b22c8f37dd91e4e803a0a6e355.tar.gz chromium_src-22e2f4a23530e0b22c8f37dd91e4e803a0a6e355.tar.bz2 | |
Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination.
Wire this into all the existing callers.
Add a new child process watcher in chrome to be notified on child process crashes. This will confirm whether users with RESULT_CODE_INVALID_SANDBOX_STATE are crashing on background start (--no-startup-window) or not. This also adds required framework to paint a sad tab UI from this class in the future.
BUG=472324, 453541
TEST=Apply patch in http://pastebin.com/uEDxngBa and verify histogram ChildProcess.InvalidSandboxStateCrash.NoStartupWindow is recorded.
Review URL: https://codereview.chromium.org/1067733006
Cr-Commit-Position: refs/heads/master@{#327380}
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 87a141d..13faa04 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -2772,6 +2772,17 @@ Therefore, the affected-histogram name has to have at least one dot in it. </summary> </histogram> +<histogram name="ChildProcess.InvalidSandboxStateCrash.NoStartupWindow" + enum="BooleanPresent"> + <owner>wfh@chromium.org</owner> + <summary> + Whether the browser command line had the switch --no-startup-window when a + child process crashed due to invalid sandbox state. Recorded when a child + process crashes if the exit code from the child process is + RESULT_CODE_INVALID_SANDBOX_STATE. + </summary> +</histogram> + <histogram name="ChildProcess.Killed" enum="ProcessType"> <obsolete> Deprecated 3/2013. Renamed to ChildProcess.Killed2. |