diff options
| author | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-17 12:37:58 +0000 |
|---|---|---|
| committer | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-17 12:37:58 +0000 |
| commit | 0716cbab63d81f732a9779cb72842cd30c23633a (patch) | |
| tree | c591430c960d81b9f58e34cde3a58e59cf7ae793 /tools | |
| parent | 6877743b0d10f2597554db43e2041e2b5a6f4d96 (diff) | |
| download | chromium_src-0716cbab63d81f732a9779cb72842cd30c23633a.zip chromium_src-0716cbab63d81f732a9779cb72842cd30c23633a.tar.gz chromium_src-0716cbab63d81f732a9779cb72842cd30c23633a.tar.bz2 | |
Added the ToolsSanityTest test case to base_unittests.
tools_sanity_test.cc contains positive tests for tools used on the buildbots.
ToolsSanityTest.MemoryLeak contains an memory leak reportable by Memcheck and
heap leak checker.
ToolsSanityTest.DataRace contains a data race reportable by ThreadSanitizer.
The corresponding suppressions are in
tools/valgrind/{memcheck,tsan}/suppressions.txt
The idea is to check the tools' reports for their presence when testing
base_unittests.
Review URL: http://codereview.chromium.org/491044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34826 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 7 | ||||
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 6 |
2 files changed, 12 insertions, 1 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 27c179f..3ec6678 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -424,7 +424,12 @@ #----------------------------------------------------------------------- # 2. intentional unit test errors, or stuff that is somehow a false positive # in our own code, or stuff that is so trivial it's not worth fixing - +{ + Memcheck sanity test (ToolsSanityTest.MemoryLeak). + Memcheck:Leak + fun:_Znam + fun:_ZN31ToolsSanityTest_MemoryLeak_Test8TestBodyEv +} { logging::InitLogging never frees filename. It would be hard to free properly. Memcheck:Leak diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index cdf7be3..b7379c2 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -163,6 +163,12 @@ fun:*CancelTestURLRequestContext*CancelTestURLRequestContext* } +{ + ThreadSanitizer sanity test (ToolsSanityTest.DataRace). + ThreadSanitizer:Race + fun:*TOOLS_SANITY_TEST_CONCURRENT_THREAD*ThreadMain* +} + ############################ # Benign races in ICU { |