diff options
| author | grt <grt@chromium.org> | 2015-04-15 08:39:14 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-15 15:39:44 +0000 |
| commit | 0732d2d1fac6f20ccd7c0df5cdddd7a24e5576f4 (patch) | |
| tree | 9baaa13dc1561642ee279d4bad71e9ce52a1416f /tools | |
| parent | f69146523e37356282404a95b14254967b103387 (diff) | |
| download | chromium_src-0732d2d1fac6f20ccd7c0df5cdddd7a24e5576f4.zip chromium_src-0732d2d1fac6f20ccd7c0df5cdddd7a24e5576f4.tar.gz chromium_src-0732d2d1fac6f20ccd7c0df5cdddd7a24e5576f4.tar.bz2 | |
Fine-grained UMA for modules with out-of-order relocs.
The original code used 50 buckets for 100 count, so it wasn't possible
to know which index was being logged. This change switches to logging
the module index as if it were an enum, and labels the enum values for
friendlier analysis.
BUG=none
R=anthonyvd@chromium.org,asvitkine@chromium.org
Review URL: https://codereview.chromium.org/1083713002
Cr-Commit-Position: refs/heads/master@{#325249}
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 690a2d7..64c448d 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -15468,7 +15468,20 @@ Therefore, the affected-histogram name has to have at least one dot in it. </summary> </histogram> +<histogram name="ModuleIntegrityVerification.RelocationsUnordered" + enum="ModuleIndex"> + <owner>grt@chromium.org</owner> + <summary> + Logged when the relocations in a module are not ordered causing the module + verification to abort. + </summary> +</histogram> + <histogram name="ModuleIntegrityVerification.RelocationsUnorderedModuleIndex"> + <obsolete> + Deprecated 04/2015; replaced by + ModuleIntegrityVerification.RelocationsUnordered. + </obsolete> <owner>anthonyvd@chromium.org</owner> <summary> Logged when the relocations in a module are not ordered causing the module @@ -55664,6 +55677,12 @@ To add a new entry, add it with any value and run test to compute valid value. <int value="4" label="No thanks"/> </enum> +<enum name="ModuleIndex" type="int"> + <int value="0" label="chrome.dll"/> + <int value="1" label="chrome_elf.dll"/> + <int value="2" label="ntdll.dll"/> +</enum> + <enum name="MouseEventFollowedByClick" type="int"> <int value="0" label="Missed event before click"/> <int value="1" label="Caught event before click"/> |