diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-10 01:04:48 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-10 01:04:48 +0000 |
| commit | 18bdd9f5eb65b0979fe6ef610aeede9bc32b1e5a (patch) | |
| tree | 98b04a0f1e64dcdcbad7123e7dcce49d7cc93546 /tools | |
| parent | f5857bc22887f8bffe9fb3135768aa0286a927eb (diff) | |
| download | chromium_src-18bdd9f5eb65b0979fe6ef610aeede9bc32b1e5a.zip chromium_src-18bdd9f5eb65b0979fe6ef610aeede9bc32b1e5a.tar.gz chromium_src-18bdd9f5eb65b0979fe6ef610aeede9bc32b1e5a.tar.bz2 | |
Fix another race condition on worker process shutdown that results in use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes.
BUG=24346
TEST=covered by valgrind
Review URL: http://codereview.chromium.org/266036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 34 |
1 files changed, 0 insertions, 34 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 8f83c3f..7dee796 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -966,24 +966,6 @@ fun:_ZN7WebCore5Frame4initEv } { - bug_23018_a - Memcheck:Addr4 - fun:_ZN12_GLOBAL__N_115KillProcessTask3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop13DoDelayedWorkEPN4base4TimeE -} -{ - # This is the same callstack as above, but for whatever reason the signature - # of the top line, KillProcessTask::Run(), is displayed differently. - bug_23018_b - Memcheck:Addr4 - fun:_ZN122_GLOBAL__N__b_slave_chromium_rel_linux_valgrind_builder_build_src_chrome_worker_webworkerclient_proxy.cc_00000000_BBD84F3C15KillProcessTask3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop13DoDelayedWorkEPN4base4TimeE -} -{ bug_23151 Memcheck:Addr4 ... @@ -1105,19 +1087,3 @@ fun:_ZN11MessageLoop11RunInternalEv fun:_ZN11MessageLoop10RunHandlerEv } -{ - bug_24346 - Memcheck:Addr4 - fun:_ZN13WebWorkerImpl25ReportPendingActivityTaskEPN7WebCore22ScriptExecutionContextEPS_b - fun:_ZN7WebCore18GenericWorkerTask2IP13WebWorkerImplS2_bbE11performTaskEPNS_22ScriptExecutionContextE - fun:_ZN13WebWorkerImpl16InvokeTaskMethodEPv - fun:_ZN3WTF31dispatchFunctionsFromMainThreadEv - fun:_Z18DispatchToFunctionIPFvvEEvT_RK6Tuple0 - fun:_ZN16RunnableFunctionIPFvvE6Tuple0E3RunEv - fun:_ZN11MessageLoop7RunTaskEP4Task - fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE - fun:_ZN11MessageLoop6DoWorkEv - fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE - fun:_ZN11MessageLoop11RunInternalEv - fun:_ZN11MessageLoop10RunHandlerEv -} |