Remove protected-access from tools/perf/pylintrc.

BUG=475714

Review URL: https://codereview.chromium.org/1103273002

Cr-Commit-Position: refs/heads/master@{#327078}

7 files changed, 12 insertions, 2 deletions

diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 3986218..93138df 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -232,6 +232,7 @@ class PageCyclerOopifTypical25(_PageCycler):
   def CreatePageSet(self, options):
     return page_sets.Typical25PageSet(run_no_page_interactions=True)
 
+
 @benchmark.Disabled # crbug.com/443730
 class PageCyclerBigJs(_PageCycler):
   page_set = page_sets.BigJsPageSet
diff --git a/tools/perf/measurements/oilpan_gc_times_unittest.py b/tools/perf/measurements/oilpan_gc_times_unittest.py
index 1d9bf5f..9b448d8 100644
--- a/tools/perf/measurements/oilpan_gc_times_unittest.py
+++ b/tools/perf/measurements/oilpan_gc_times_unittest.py
@@ -63,7 +63,6 @@ class OilpanGCTimesTestData(object):
   def ClearResults(self):
     self._results = page_test_results.PageTestResults()
 
-
 class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
   """Smoke test for Oilpan GC pause time measurements.
 
@@ -80,6 +79,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
   def setUp(self):
     self._options = options_for_unittests.GetCopy()
 
+  # Disable for accessing private API of _OilpanGCTimesBase.
+  # pylint: disable=protected-access
   def testForParsingOldFormat(self):
     def getMetric(results, name):
       metrics = results.FindAllPageSpecificValuesNamed(name)
@@ -109,6 +110,8 @@ class OilpanGCTimesTest(page_test_test_case.PageTestTestCase):
     self.assertEquals(2, len(getMetric(results,
                                        'oilpan_forced_complete_sweep')))
 
+  # Disable for accessing private API of _OilpanGCTimesBase.
+  # pylint: disable=protected-access
   def testForParsing(self):
     def getMetric(results, name):
       metrics = results.FindAllPageSpecificValuesNamed(name)
diff --git a/tools/perf/measurements/task_execution_time_unittest.py b/tools/perf/measurements/task_execution_time_unittest.py
index 827377f..8a76312 100644
--- a/tools/perf/measurements/task_execution_time_unittest.py
+++ b/tools/perf/measurements/task_execution_time_unittest.py
@@ -25,6 +25,8 @@ class TestTaskExecutionTimePage(page_module.Page):
       action_runner.ScrollPage()
 
 
+# Disable for accessing private API of task_execution_time.
+# pylint: disable=protected-access
 class TaskExecutionTimeUnitTest(page_test_test_case.PageTestTestCase):
 
   def setUp(self):
diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py
index 1f3cb77..ebb36f4 100644
--- a/tools/perf/measurements/v8_gc_times.py
+++ b/tools/perf/measurements/v8_gc_times.py
@@ -169,6 +169,7 @@ def _FindV8EventStatForEvent(v8_event_stats_list, event_name):
 def _ParentIdleTask(event):
   parent = event.parent_slice
   while parent:
+    # pylint: disable=protected-access
     if parent.name == V8GCTimes._IDLE_TASK_PARENT:
       return parent
     parent = parent.parent_slice
diff --git a/tools/perf/measurements/v8_gc_times_unittest.py b/tools/perf/measurements/v8_gc_times_unittest.py
index c13089c..9212277 100644
--- a/tools/perf/measurements/v8_gc_times_unittest.py
+++ b/tools/perf/measurements/v8_gc_times_unittest.py
@@ -46,6 +46,7 @@ class V8GCTimesTestPageHelper(object):
     results.WillRunPage(page)
 
     v8_gc_times_metric = v8_gc_times.V8GCTimes()
+    # pylint: disable=protected-access
     v8_gc_times_metric._renderer_process = self._renderer_process
 
     # Finalize the timeline import.
diff --git a/tools/perf/pylintrc b/tools/perf/pylintrc
index 8ba763a..964cc02 100644
--- a/tools/perf/pylintrc
+++ b/tools/perf/pylintrc
@@ -2,7 +2,7 @@
 
 # Disable the message, report, category or checker with the given id(s).
 # TODO(perf-owners): Reduce this list to as small as possible.
-disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,protected-access,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,useless-else-on-loop,unused-argument
+disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,useless-else-on-loop,unused-argument
 
 
 [REPORTS]
diff --git a/tools/perf/update_reference_build_unittest.py b/tools/perf/update_reference_build_unittest.py
index 2eb9fb0..e02dee0 100644
--- a/tools/perf/update_reference_build_unittest.py
+++ b/tools/perf/update_reference_build_unittest.py
@@ -6,6 +6,8 @@ import unittest
 import update_reference_build as update_ref_build
 
 
+# Disable for accessing private API of update_reference_build class.
+# pylint: disable=protected-access
 class UpdateReferenceBuildUnittest(unittest.TestCase):
   def testInit(self):
     @classmethod