diff options
| author | schenney <schenney@chromium.org> | 2015-04-23 11:31:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-23 18:31:18 +0000 |
| commit | 68d12cfa87a2aeffba0caa2e31e99e5c80744780 (patch) | |
| tree | 13ee78a0afc6bf516766670a2b6f5cd0bb98d0c4 /tools | |
| parent | e771ecf956c01834866e5c1caaad97977ca6fda4 (diff) | |
| download | chromium_src-68d12cfa87a2aeffba0caa2e31e99e5c80744780.zip chromium_src-68d12cfa87a2aeffba0caa2e31e99e5c80744780.tar.gz chromium_src-68d12cfa87a2aeffba0caa2e31e99e5c80744780.tar.bz2 | |
Add support for painting disabled mode for Slimming Paint
Plumb the "painting disabled" mode through to disable the GraphicsContext
in Slimming Paint perf testing. This mode causes Graphics Context to do
no work, producing empty SkPictures for all drawing display items. This
seems the best interpretation of "painting disabled".
The perf results lines for slimming_paint record_time_null_canvas will
go to zero after this patch, and the record_time_construction_disabled
result will start appearing and be zero for non slimming paint.
R=sullivan,skyostil,enne,ajuma
BUG=471348
Review URL: https://codereview.chromium.org/1104433005
Cr-Commit-Position: refs/heads/master@{#326586}
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/measurements/rasterize_and_record_micro.py | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/tools/perf/measurements/rasterize_and_record_micro.py b/tools/perf/measurements/rasterize_and_record_micro.py index 412e263..131cc5e 100644 --- a/tools/perf/measurements/rasterize_and_record_micro.py +++ b/tools/perf/measurements/rasterize_and_record_micro.py @@ -87,10 +87,12 @@ class RasterizeAndRecordMicro(page_test.PageTest): record_time_painting_disabled = data['record_time_painting_disabled_ms'] # TODO(schenney): Remove this workaround when reference builds get past # the change that adds this comment. - if ('record_time_caching_disabled_ms' in data): - record_time_caching_disabled = data['record_time_caching_disabled_ms'] - else: - record_time_caching_disabled = 0 + record_time_caching_disabled = \ + data.get('record_time_caching_disabled_ms', 0) + # TODO(schenney): Remove this workaround when reference builds get past + # the change that adds this comment. + record_time_construction_disabled = \ + data.get('record_time_construction_disabled_ms', 0) results.AddValue(scalar.ScalarValue( results.current_page, 'record_time_sk_null_canvas', 'ms', record_time_sk_null_canvas)) @@ -100,6 +102,9 @@ class RasterizeAndRecordMicro(page_test.PageTest): results.AddValue(scalar.ScalarValue( results.current_page, 'record_time_caching_disabled', 'ms', record_time_caching_disabled)) + results.AddValue(scalar.ScalarValue( + results.current_page, 'record_time_construction_disabled', 'ms', + record_time_construction_disabled)) if self._report_detailed_results: pixels_rasterized_with_non_solid_color = \ |