diff options
author | aiolos <aiolos@chromium.org> | 2014-12-08 17:28:09 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-12-09 01:28:23 +0000 |
commit | 927b7cf919416b017a7262ad96e83da9cc8f000a (patch) | |
tree | 83899791399ab3d1da0701a92eb65b23954f57b8 /tools | |
parent | be0a2b04eda3942ed7e3f87d27f5208be930eb0a (diff) | |
download | chromium_src-927b7cf919416b017a7262ad96e83da9cc8f000a.zip chromium_src-927b7cf919416b017a7262ad96e83da9cc8f000a.tar.gz chromium_src-927b7cf919416b017a7262ad96e83da9cc8f000a.tar.bz2 |
Fail on page_set_archive_info permission or credentials error when no archive file is present.
BUG=435063
Review URL: https://codereview.chromium.org/782423003
Cr-Commit-Position: refs/heads/master@{#307394}
Diffstat (limited to 'tools')
-rw-r--r-- | tools/telemetry/telemetry/page/page_set_archive_info.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/telemetry/telemetry/page/page_set_archive_info.py b/tools/telemetry/telemetry/page/page_set_archive_info.py index eb07998..0d74740 100644 --- a/tools/telemetry/telemetry/page/page_set_archive_info.py +++ b/tools/telemetry/telemetry/page/page_set_archive_info.py @@ -35,6 +35,9 @@ class PageSetArchiveInfo(object): if not os.path.exists(self._base_dir): os.makedirs(self._base_dir) + # TODO(aiolos): We should take this out of init if we reduce the number of + # supported code paths/configs using archive_info when switching over to + # user_stories. # Download all .wpr files. if not ignore_archive: if not self._bucket: @@ -52,6 +55,11 @@ class PageSetArchiveInfo(object): # simply warn. logging.warning('Need credentials to update WPR archive: %s', archive_path) + else: + logging.error("You either aren't authenticated or don't have " + "permission to use the archives for this page set." + "\nYou may need to run gsutil config") + raise # Map from the relative path (as it appears in the metadata file) of the # .wpr file to a list of page names it supports. |