diff options
| author | aurimas@chromium.org <aurimas@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-08 19:27:00 +0000 |
|---|---|---|
| committer | aurimas@chromium.org <aurimas@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-08 19:27:00 +0000 |
| commit | a8aaede1647c6d40ec0ed275a800396a19136d2c (patch) | |
| tree | 36a99a171982c434405f8abf1733a4b8b094e626 /tools | |
| parent | 47e70d03bac8c0cbb3420183c0edb9ded20711b4 (diff) | |
| download | chromium_src-a8aaede1647c6d40ec0ed275a800396a19136d2c.zip chromium_src-a8aaede1647c6d40ec0ed275a800396a19136d2c.tar.gz chromium_src-a8aaede1647c6d40ec0ed275a800396a19136d2c.tar.bz2 | |
[Checkstyle] Update static variable and constant names to match style guides.
- Static field names start with s.
- static final fields (constants) are ALL_CAPS_WITH_UNDERSCORES.
http://source.android.com/source/code-style.html#follow-field-naming-conventions
BUG=318404
TBR=qinmin
Review URL: https://codereview.chromium.org/455523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288416 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/android/checkstyle/chromium-style-5.0.xml | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/android/checkstyle/chromium-style-5.0.xml b/tools/android/checkstyle/chromium-style-5.0.xml index a760b29..7a50d31 100644 --- a/tools/android/checkstyle/chromium-style-5.0.xml +++ b/tools/android/checkstyle/chromium-style-5.0.xml @@ -45,7 +45,7 @@ <property name="severity" value="warning"/> </module> <module name="ConstantName"> - <property name="severity" value="warning"/> + <property name="severity" value="error"/> <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA-Z0-9]*)$"/> <message key="name.invalidPattern" value="Static final field names must either be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g. AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/> </module> @@ -58,6 +58,7 @@ </module> <!-- Static field names start with s. --> <module name="StaticVariableName"> + <property name="severity" value="error"/> <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/> <property name="applyToPublic" value="false"/> <message key="name.invalidPattern" value="Static field names start with s."/> |