[Telemetry] Reenable unused-import lint check for telemetry.

Fix all the places that have unused-import in telemetry.

BUG=475714

Review URL: https://codereview.chromium.org/1051323006

Cr-Commit-Position: refs/heads/master@{#326298}

54 files changed, 24 insertions, 111 deletions

diff --git a/tools/telemetry/pylintrc b/tools/telemetry/pylintrc
index b112c52..1107774 100644
--- a/tools/telemetry/pylintrc
+++ b/tools/telemetry/pylintrc
@@ -1,8 +1,8 @@
 [MESSAGES CONTROL]
 
 # Disable the message, report, category or checker with the given id(s).
-# TODO(nednguyen): Remove unusued-argument and unused-import from this list.
-disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,import-error,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,protected-access,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,unnecessary-semicolon,unpacking-non-sequence,useless-else-on-loop,unused-argument,unused-import
+# # TODO(nednguyen): Remove unusued-argument from this list.
+disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,old-style-class,protected-access,reimported,star-args,super-on-old-class,superfluous-parens,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,unnecessary-semicolon,unpacking-non-sequence,cyclic-import, unused-argument
 
 
 [REPORTS]
diff --git a/tools/telemetry/telemetry/benchmark_runner.py b/tools/telemetry/telemetry/benchmark_runner.py
index 1113f33..cfe8e87 100644
--- a/tools/telemetry/telemetry/benchmark_runner.py
+++ b/tools/telemetry/telemetry/benchmark_runner.py
@@ -18,9 +18,7 @@ from telemetry.core import browser_finder
 from telemetry.core import browser_options
 from telemetry.core import command_line
 from telemetry.core import discover
-from telemetry.core import util
 from telemetry import decorators
-from telemetry.util import find_dependencies
 
 
 class Environment(object):
diff --git a/tools/telemetry/telemetry/benchmark_unittest.py b/tools/telemetry/telemetry/benchmark_unittest.py
index 3917d8b..488706f 100644
--- a/tools/telemetry/telemetry/benchmark_unittest.py
+++ b/tools/telemetry/telemetry/benchmark_unittest.py
@@ -60,7 +60,7 @@ class BenchmarkTest(unittest.TestCase):
   def testPageTestWithCompatibleUserStory(self):
     original_run_fn = user_story_runner.Run
     was_run = [False]
-    def RunStub(*_, **__):
+    def RunStub(*_arg, **_kwargs):
       was_run[0] = True
     user_story_runner.Run = RunStub
 
diff --git a/tools/telemetry/telemetry/core/_bitmap.py b/tools/telemetry/telemetry/core/_bitmap.py
index 89aedfc..808e939 100644
--- a/tools/telemetry/telemetry/core/_bitmap.py
+++ b/tools/telemetry/telemetry/core/_bitmap.py
@@ -8,7 +8,6 @@ tools: crop, find bounding box of a color and compute histogram of color values.
 """
 
 import array
-import base64
 import cStringIO
 import struct
 import subprocess
diff --git a/tools/telemetry/telemetry/core/android_app_unittest.py b/tools/telemetry/telemetry/core/android_app_unittest.py
index 91a5a0d..fa38386 100644
--- a/tools/telemetry/telemetry/core/android_app_unittest.py
+++ b/tools/telemetry/telemetry/core/android_app_unittest.py
@@ -6,13 +6,16 @@ import logging
 import time
 import unittest
 
-from pylib.device import intent
 from telemetry.core import android_app
 from telemetry.core.backends import android_app_backend
 from telemetry.core import platform as platform_module
 from telemetry.core.platform import android_device
+from telemetry.core import util
 from telemetry.unittest_util import options_for_unittests
 
+util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
+from pylib.device import intent  # pylint: disable=import-error
+
 
 class AndroidAppTest(unittest.TestCase):
   def setUp(self):
diff --git a/tools/telemetry/telemetry/core/backends/android_app_backend.py b/tools/telemetry/telemetry/core/backends/android_app_backend.py
index d218657..b2c56f2 100644
--- a/tools/telemetry/telemetry/core/backends/android_app_backend.py
+++ b/tools/telemetry/telemetry/core/backends/android_app_backend.py
@@ -3,15 +3,12 @@
 # found in the LICENSE file.
 
 import re
-import time
 
 from telemetry.core import android_process
-from telemetry.core.backends import adb_commands
 from telemetry.core.backends import android_browser_backend_settings
 from telemetry.core.backends import android_command_line_backend
 from telemetry.core.backends import app_backend
 from telemetry.core import util
-from telemetry.core import web_contents
 
 
 class AndroidAppBackend(app_backend.AppBackend):
diff --git a/tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py b/tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py
index b5e70f1..da57d09 100644
--- a/tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import logging
 import unittest
 
 from telemetry import benchmark
@@ -16,7 +15,7 @@ class _MockBackendSettings(object):
   def __init__(self, path):
     self._path = path
 
-  def GetCommandLineFile(self, _is_user_debug_build):
+  def GetCommandLineFile(self, _):
     return self._path
 
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
index c3f1560..0a4de84 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
@@ -3,9 +3,7 @@
 # found in the LICENSE file.
 
 import logging
-import pipes
 import sys
-import time
 
 from telemetry.core.backends import adb_commands
 from telemetry.core.backends import android_command_line_backend
@@ -18,7 +16,6 @@ from telemetry.core.platform import android_platform_backend as \
 from telemetry.core import util
 
 util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
-from pylib.device import device_errors  # pylint: disable=F0401
 from pylib.device import intent  # pylint: disable=F0401
 
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index c7d29a6..c46fdd30 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -2,22 +2,16 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import contextlib
-import httplib
-import json
 import logging
 import pprint
 import re
-import socket
 import sys
-import urllib2
 
 from telemetry.core.backends import browser_backend
 from telemetry.core.backends.chrome import extension_backend
 from telemetry.core.backends.chrome import system_info_backend
 from telemetry.core.backends.chrome import tab_list_backend
 from telemetry.core.backends.chrome_inspector import devtools_client_backend
-from telemetry.core.backends.chrome_inspector import devtools_http
 from telemetry.core import exceptions
 from telemetry.core import forwarders
 from telemetry.core import user_agent
diff --git a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
index b788a45..3b2f109 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py
@@ -6,7 +6,6 @@
 
 import logging
 import re
-import subprocess
 
 from telemetry.core.backends.chrome import ios_browser_backend
 from telemetry.core.backends.chrome_inspector import inspector_backend
@@ -15,7 +14,6 @@ from telemetry.core import platform
 from telemetry.core.platform import ios_device
 from telemetry.core.platform import ios_platform_backend
 from telemetry.core import possible_browser
-from telemetry import decorators
 
 
 # Key matches output from ios-webkit-debug-proxy and the value is a readable
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py
index b824b4e..65f44f7 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend_unittest.py
@@ -2,8 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from telemetry.core.backends.chrome_inspector import devtools_client_backend
-from telemetry.core.backends.chrome_inspector import devtools_http
 from telemetry import decorators
 from telemetry.unittest_util import browser_test_case
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http_unittest.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http_unittest.py
index e148b59..092a462 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http_unittest.py
@@ -2,10 +2,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import httplib
-import socket
 import unittest
-import urllib2
 
 from telemetry.core.backends.chrome_inspector import devtools_http
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
index 0f0df14..1290153 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
@@ -17,9 +17,7 @@ from telemetry.core.backends.chrome_inspector import inspector_runtime
 from telemetry.core.backends.chrome_inspector import inspector_websocket
 from telemetry.core.backends.chrome_inspector import websocket
 from telemetry.core import exceptions
-from telemetry.core import util
 from telemetry import decorators
-from telemetry.image_processing import image_util
 from telemetry.timeline import model as timeline_model_module
 from telemetry.timeline import trace_data as trace_data_module
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py
index 89a7ada..741928b 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py
@@ -4,9 +4,7 @@
 
 import collections
 import logging
-import sys
 
-from telemetry.core.backends.chrome_inspector import inspector_backend
 from telemetry.core import exceptions
 
 
@@ -42,7 +40,7 @@ class InspectorBackendList(collections.Sequence):
   def GetContextInfo(self, context_id):
     return self._devtools_context_map_backend.GetContextInfo(context_id)
 
-  def ShouldIncludeContext(self, _context):
+  def ShouldIncludeContext(self, _):
     """Override this method to control which contexts are included."""
     return True
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py
index 8afc18e..ed04623 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py
@@ -1,7 +1,6 @@
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
-import sys
 import time
 
 from telemetry.image_processing import image_util
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page_unittest.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page_unittest.py
index 61a9bf9..5f94010 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page_unittest.py
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from telemetry import decorators
 from telemetry.image_processing import image_util
 from telemetry.unittest_util import tab_test_case
 
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py
index 3ea734d..e63e23e 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_websocket.py
@@ -2,11 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import collections
 import json
 import logging
-import socket
-import time
 
 from telemetry.core.backends.chrome_inspector import websocket
 from telemetry.core import exceptions
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py
index 8253f82..716b153 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/tracing_backend_unittest.py
@@ -2,24 +2,19 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import cStringIO
-import json
 import unittest
 
-from telemetry.core.backends.chrome_inspector import inspector_websocket
 from telemetry.core.backends.chrome_inspector import tracing_backend
 from telemetry.core.backends.chrome_inspector import websocket
 from telemetry.core.platform import tracing_category_filter
 from telemetry.core.platform import tracing_options
 from telemetry.core import util
-from telemetry import decorators
 from telemetry.timeline import model as model_module
-from telemetry.timeline import trace_data as trace_data_module
 from telemetry.unittest_util import simple_mock
 from telemetry.unittest_util import tab_test_case
 
 util.AddDirToPythonPath(util.GetTelemetryDir(), 'third_party', 'mock')
-import mock
+import mock  # pylint:disable=import-error
 
 
 class FakeInspectorWebsocket(object):
diff --git a/tools/telemetry/telemetry/core/device_finder.py b/tools/telemetry/telemetry/core/device_finder.py
index beae258..fe3f83f 100644
--- a/tools/telemetry/telemetry/core/device_finder.py
+++ b/tools/telemetry/telemetry/core/device_finder.py
@@ -4,8 +4,6 @@
 
 """Finds devices that can be controlled by telemetry."""
 
-import logging
-
 from telemetry.core.platform import android_device
 from telemetry.core.platform import cros_device
 from telemetry.core.platform import desktop_device
diff --git a/tools/telemetry/telemetry/core/platform/android_device_unittest.py b/tools/telemetry/telemetry/core/platform/android_device_unittest.py
index 6e7609b..b8a61dd 100644
--- a/tools/telemetry/telemetry/core/platform/android_device_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/android_device_unittest.py
@@ -4,7 +4,6 @@
 
 import unittest
 
-from telemetry import benchmark
 from telemetry.core import browser_options
 from telemetry.core.platform import android_device
 from telemetry.core.platform import android_platform_backend
@@ -43,7 +42,7 @@ class GetDeviceTest(unittest.TestCase):
   def testNoAdbReturnsNone(self):
     finder_options = browser_options.BrowserFinderOptions()
 
-    def NoAdb(*_, **__):
+    def NoAdb(*_1, **_2):
       raise OSError('not found')
     self._android_device_stub.subprocess.Popen = NoAdb
 
diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
index 00aad43..f84a4ea 100644
--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
@@ -8,7 +8,6 @@ import re
 import shutil
 import subprocess
 import tempfile
-import time
 
 from telemetry.core.backends import adb_commands
 from telemetry.core import exceptions
@@ -32,22 +31,21 @@ from telemetry.util import external_modules
 psutil = external_modules.ImportOptionalModule('psutil')
 util.AddDirToPythonPath(util.GetChromiumSrcDir(),
                         'third_party', 'webpagereplay')
-import adb_install_cert  # pylint: disable=F0401
-import certutils  # pylint: disable=F0401
-import platformsettings  # pylint: disable=F0401
+import adb_install_cert  # pylint: disable=import-error
+import certutils  # pylint: disable=import-error
+import platformsettings  # pylint: disable=import-error
 
 # Get build/android scripts into our path.
 util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'build', 'android')
-from pylib.device import battery_utils # pylint: disable=F0401
-from pylib.device import device_errors  # pylint: disable=F0401
-from pylib.perf import cache_control  # pylint: disable=F0401
-from pylib.perf import perf_control  # pylint: disable=F0401
-from pylib.perf import thermal_throttle  # pylint: disable=F0401
-from pylib.utils import device_temp_file # pylint: disable=F0401
-from pylib import screenshot  # pylint: disable=F0401
+from pylib.device import battery_utils # pylint: disable=import-error
+from pylib.perf import cache_control  # pylint: disable=import-error
+from pylib.perf import perf_control  # pylint: disable=import-error
+from pylib.perf import thermal_throttle  # pylint: disable=import-error
+from pylib.utils import device_temp_file # pylint: disable=import-error
+from pylib import screenshot  # pylint: disable=import-error
 
 try:
-  from pylib.perf import surface_stats_collector  # pylint: disable=F0401
+  from pylib.perf import surface_stats_collector  # pylint: disable=import-error
 except Exception:
   surface_stats_collector = None
 
diff --git a/tools/telemetry/telemetry/core/platform/cros_interface.py b/tools/telemetry/telemetry/core/platform/cros_interface.py
index a3c3316..92527d0 100644
--- a/tools/telemetry/telemetry/core/platform/cros_interface.py
+++ b/tools/telemetry/telemetry/core/platform/cros_interface.py
@@ -6,7 +6,6 @@ import logging
 import os
 import re
 import shutil
-import socket
 import stat
 import subprocess
 import tempfile
diff --git a/tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py
index 1059285..8e714e3 100644
--- a/tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py
@@ -10,7 +10,7 @@ from telemetry.core import util
 from telemetry import decorators
 
 util.AddDirToPythonPath(util.GetTelemetryDir(), 'third_party', 'mock')
-import mock
+import mock  # pylint:disable=import-error
 
 
 class LinuxPlatformBackendTest(unittest.TestCase):
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
index f6da6ac..5ca608e 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py
@@ -2,11 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-from collections import defaultdict
 import csv
 import logging
 
-from telemetry.core import util
 from telemetry.core.platform.power_monitor import sysfs_power_monitor
 
 
diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py
index be966b4..cc0b6c0 100644
--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor_unittest.py
@@ -2,11 +2,9 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import os
 import unittest
 
 from telemetry.core.platform.power_monitor import android_dumpsys_power_monitor
-from telemetry.core.util import GetUnittestDataDir
 
 
 class DumpsysPowerMonitorMonitorTest(unittest.TestCase):
diff --git a/tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py b/tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py
index d32a513..2e27d7d 100644
--- a/tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/profiler/trace_profiler_unittest.py
@@ -8,7 +8,6 @@ import tempfile
 import zipfile
 
 from telemetry.core.platform.profiler import trace_profiler
-from telemetry import decorators
 from telemetry.unittest_util import tab_test_case
 
 
diff --git a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
index fbb0c1c..2e86f6e 100644
--- a/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
+++ b/tools/telemetry/telemetry/core/platform/tracing_controller_backend.py
@@ -7,7 +7,6 @@ import os
 from telemetry.core import discover
 from telemetry.core.platform import tracing_agent
 from telemetry.core.platform.tracing_agent import chrome_tracing_agent
-from telemetry.core.platform.tracing_agent import display_tracing_agent
 from telemetry.core.platform import tracing_category_filter
 from telemetry.core.platform import tracing_options
 from telemetry.core import util
@@ -28,7 +27,6 @@ class TracingControllerBackend(object):
     self._current_trace_options = None
     self._current_category_filter = None
     self._current_chrome_tracing_agent = None
-    self._current_display_tracing_agent = None
     self._supported_agents_classes = [
         agent_classes for agent_classes in _IterAllTracingAgentClasses() if
         agent_classes.IsSupported(platform_backend)]
diff --git a/tools/telemetry/telemetry/image_processing/histogram_unittest.py b/tools/telemetry/telemetry/image_processing/histogram_unittest.py
index 69e8d5a..9e24f13 100644
--- a/tools/telemetry/telemetry/image_processing/histogram_unittest.py
+++ b/tools/telemetry/telemetry/image_processing/histogram_unittest.py
@@ -4,7 +4,6 @@
 
 import unittest
 
-from telemetry import benchmark
 from telemetry.image_processing import histogram
 from telemetry.image_processing import image_util
 from telemetry.image_processing.rgba_color import RgbaColor
diff --git a/tools/telemetry/telemetry/image_processing/image_util_unittest.py b/tools/telemetry/telemetry/image_processing/image_util_unittest.py
index 540bf3e..6ca537e 100644
--- a/tools/telemetry/telemetry/image_processing/image_util_unittest.py
+++ b/tools/telemetry/telemetry/image_processing/image_util_unittest.py
@@ -6,7 +6,6 @@ import os
 import tempfile
 import unittest
 
-from telemetry import benchmark
 from telemetry.core import util
 from telemetry.image_processing import image_util
 from telemetry.image_processing.rgba_color import RgbaColor
diff --git a/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py b/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py
index da98466..08183fa 100644
--- a/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py
+++ b/tools/telemetry/telemetry/internal/actions/action_runner_unittest.py
@@ -15,7 +15,7 @@ from telemetry.unittest_util import tab_test_case
 from telemetry.web_perf import timeline_interaction_record as tir_module
 
 util.AddDirToPythonPath(util.GetTelemetryDir(), 'third_party', 'mock')
-import mock
+import mock  # pylint:disable=import-error
 
 
 class ActionRunnerInteractionTest(tab_test_case.TabTestCase):
diff --git a/tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py b/tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py
index 4e1c0b3..70813d6 100644
--- a/tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py
+++ b/tools/telemetry/telemetry/internal/actions/mouse_click_unittest.py
@@ -2,8 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import os
-
 from telemetry.core import exceptions
 from telemetry.internal.actions import mouse_click
 from telemetry.unittest_util import tab_test_case
diff --git a/tools/telemetry/telemetry/internal/actions/scroll_unittest.py b/tools/telemetry/telemetry/internal/actions/scroll_unittest.py
index 29bd285..d0798c8 100644
--- a/tools/telemetry/telemetry/internal/actions/scroll_unittest.py
+++ b/tools/telemetry/telemetry/internal/actions/scroll_unittest.py
@@ -4,10 +4,8 @@
 
 import os
 
-from telemetry import decorators
 from telemetry.internal.actions import scroll
 from telemetry.unittest_util import tab_test_case
-from telemetry.core.backends.chrome_inspector import devtools_client_backend
 
 class ScrollActionTest(tab_test_case.TabTestCase):
   def testScrollAction(self):
diff --git a/tools/telemetry/telemetry/page/action_runner.py b/tools/telemetry/telemetry/page/action_runner.py
index b42157a..496adce 100644
--- a/tools/telemetry/telemetry/page/action_runner.py
+++ b/tools/telemetry/telemetry/page/action_runner.py
@@ -6,7 +6,6 @@ import logging
 import time
 import urlparse
 
-from telemetry.core import exceptions
 from telemetry.internal.actions.drag import DragAction
 from telemetry.internal.actions.javascript_click import ClickElementAction
 from telemetry.internal.actions.loop import LoopAction
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index be3d5ee..5a0b9f6 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -2,8 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import csv
-import inspect
 import os
 
 from telemetry.page import page as page_module
diff --git a/tools/telemetry/telemetry/page/page_set_unittest.py b/tools/telemetry/telemetry/page/page_set_unittest.py
index 0e764a2..9545c70 100644
--- a/tools/telemetry/telemetry/page/page_set_unittest.py
+++ b/tools/telemetry/telemetry/page/page_set_unittest.py
@@ -8,7 +8,6 @@ import unittest
 
 from telemetry.page import page
 from telemetry.page import page_set
-from telemetry.util import cloud_storage
 
 
 class TestPageSet(unittest.TestCase):
diff --git a/tools/telemetry/telemetry/page/shared_page_state_unittest.py b/tools/telemetry/telemetry/page/shared_page_state_unittest.py
index b45f65b..2731ef6 100644
--- a/tools/telemetry/telemetry/page/shared_page_state_unittest.py
+++ b/tools/telemetry/telemetry/page/shared_page_state_unittest.py
@@ -5,14 +5,12 @@
 import tempfile
 import unittest
 
-from telemetry.core import browser_finder
 from telemetry.core import wpr_modes
 from telemetry.page import page
 from telemetry.page import page_set
 from telemetry.page import page_test
 from telemetry.page import shared_page_state
 from telemetry.unittest_util import options_for_unittests
-from telemetry import user_story
 from telemetry.user_story import user_story_runner
 from telemetry.user_story import user_story_set
 
diff --git a/tools/telemetry/telemetry/results/json_output_formatter.py b/tools/telemetry/telemetry/results/json_output_formatter.py
index 7ef539d..7564755 100644
--- a/tools/telemetry/telemetry/results/json_output_formatter.py
+++ b/tools/telemetry/telemetry/results/json_output_formatter.py
@@ -3,10 +3,8 @@
 # found in the LICENSE file.
 
 import json
-import os
 
 from telemetry.results import output_formatter
-from telemetry.util import file_handle
 
 
 def ResultsAsDict(page_test_results, benchmark_metadata):
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index 723748b..336621c 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -5,7 +5,6 @@
 import collections
 import copy
 import datetime
-import itertools
 import logging
 import random
 import sys
diff --git a/tools/telemetry/telemetry/results/user_story_run_unittest.py b/tools/telemetry/telemetry/results/user_story_run_unittest.py
index 0af37a2..41f076c 100644
--- a/tools/telemetry/telemetry/results/user_story_run_unittest.py
+++ b/tools/telemetry/telemetry/results/user_story_run_unittest.py
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import os
 import unittest
 
 from telemetry.results import user_story_run
diff --git a/tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py b/tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py
index 25015e4..bdb6da2 100644
--- a/tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py
+++ b/tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import json
 import unittest
 
 from telemetry.timeline import model as timeline_model
diff --git a/tools/telemetry/telemetry/timeline/trace_data.py b/tools/telemetry/telemetry/timeline/trace_data.py
index 859ec83..25b129d 100644
--- a/tools/telemetry/telemetry/timeline/trace_data.py
+++ b/tools/telemetry/telemetry/timeline/trace_data.py
@@ -3,7 +3,6 @@
 # found in the LICENSE file.
 
 import json
-import numbers
 
 class NonSerializableTraceData(Exception):
   """Raised when raw trace data cannot be serialized to TraceData."""
diff --git a/tools/telemetry/telemetry/timeline/trace_data_unittest.py b/tools/telemetry/telemetry/timeline/trace_data_unittest.py
index 4c24317..491142e 100644
--- a/tools/telemetry/telemetry/timeline/trace_data_unittest.py
+++ b/tools/telemetry/telemetry/timeline/trace_data_unittest.py
@@ -4,10 +4,8 @@
 
 import cStringIO
 import json
-import logging
 import unittest
 
-from telemetry.core import util
 from telemetry.timeline import trace_data
 
 class TraceDataTest(unittest.TestCase):
diff --git a/tools/telemetry/telemetry/timeline/trace_event_importer.py b/tools/telemetry/telemetry/timeline/trace_event_importer.py
index 49aad15..548473a 100644
--- a/tools/telemetry/telemetry/timeline/trace_event_importer.py
+++ b/tools/telemetry/telemetry/timeline/trace_event_importer.py
@@ -8,8 +8,6 @@ https://code.google.com/p/trace-viewer/
 """
 
 import copy
-import json
-import re
 
 import telemetry.timeline.async_slice as tracing_async_slice
 import telemetry.timeline.flow_event as tracing_flow_event
diff --git a/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py b/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
index e8a3d36..acd8b66 100644
--- a/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
+++ b/tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py
@@ -2,13 +2,11 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import json
 import unittest
 
 import telemetry.timeline.counter as tracing_counter
 import telemetry.timeline.model as timeline_model
 from telemetry.timeline import trace_data as trace_data_module
-from telemetry.timeline import trace_event_importer
 
 
 def FindEventNamed(events, name):
diff --git a/tools/telemetry/telemetry/user_story/android/shared_app_state.py b/tools/telemetry/telemetry/user_story/android/shared_app_state.py
index ef3eb8c..979182d 100644
--- a/tools/telemetry/telemetry/user_story/android/shared_app_state.py
+++ b/tools/telemetry/telemetry/user_story/android/shared_app_state.py
@@ -1,12 +1,9 @@
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
-import os
-
 from telemetry.core import platform
 from telemetry.core.platform import android_device
 from telemetry.core.platform import android_platform
-from telemetry.core import wpr_modes
 from telemetry.user_story import shared_user_story_state
 from telemetry.web_perf import timeline_based_measurement
 
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner.py b/tools/telemetry/telemetry/user_story/user_story_runner.py
index 4f3acba..331441a 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner.py
@@ -5,19 +5,15 @@
 import logging
 import optparse
 import os
-import random
 import sys
 import time
 
 from telemetry.core import exceptions
 from telemetry.core import wpr_modes
 from telemetry.internal.actions import page_action
-from telemetry import page as page_module
-from telemetry.page import page_set as page_set_module
 from telemetry.page import page_test
 from telemetry.results import results_options
 from telemetry.user_story import user_story_filter
-from telemetry.user_story import user_story_set as user_story_set_module
 from telemetry.util import cloud_storage
 from telemetry.util import exception_formatter
 from telemetry.value import failure
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
index cc8489d..1e9c74a 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
@@ -21,7 +21,6 @@ from telemetry.user_story import user_story_set
 from telemetry.util import cloud_storage
 from telemetry.util import exception_formatter as exception_formatter_module
 from telemetry.value import scalar
-from telemetry.value import string
 from telemetry.web_perf import timeline_based_measurement
 from telemetry.wpr import archive_info
 
diff --git a/tools/telemetry/telemetry/util/cloud_storage_unittest.py b/tools/telemetry/telemetry/util/cloud_storage_unittest.py
index 7ef373a..7e40f44 100644
--- a/tools/telemetry/telemetry/util/cloud_storage_unittest.py
+++ b/tools/telemetry/telemetry/util/cloud_storage_unittest.py
@@ -5,8 +5,6 @@
 import os
 import unittest
 
-from telemetry import decorators
-
 from telemetry.unittest_util import system_stub
 from telemetry.util import cloud_storage
 
diff --git a/tools/telemetry/telemetry/util/file_handle.py b/tools/telemetry/telemetry/util/file_handle.py
index 55c015c..8133b0d 100644
--- a/tools/telemetry/telemetry/util/file_handle.py
+++ b/tools/telemetry/telemetry/util/file_handle.py
@@ -3,7 +3,6 @@
 # found in the LICENSE file.
 
 import os
-import shutil
 
 
 _next_file_id = 0
diff --git a/tools/telemetry/telemetry/util/file_handle_unittest.py b/tools/telemetry/telemetry/util/file_handle_unittest.py
index 12fc4ca..da3ca90 100644
--- a/tools/telemetry/telemetry/util/file_handle_unittest.py
+++ b/tools/telemetry/telemetry/util/file_handle_unittest.py
@@ -3,7 +3,6 @@
 # found in the LICENSE file.
 
 import os
-import shutil
 import tempfile
 import unittest
 
diff --git a/tools/telemetry/telemetry/value/trace.py b/tools/telemetry/telemetry/value/trace.py
index 176eb29..a31be2c 100644
--- a/tools/telemetry/telemetry/value/trace.py
+++ b/tools/telemetry/telemetry/value/trace.py
@@ -21,7 +21,7 @@ from telemetry import value as value_module
 util.AddDirToPythonPath(
     util.GetChromiumSrcDir(), 'third_party', 'trace-viewer')
 
-from trace_viewer.build import trace2html
+from trace_viewer.build import trace2html  # pylint:disable=import-error
 
 class TraceValue(value_module.Value):
   def __init__(self, page, trace_data, important=False, description=None):
diff --git a/tools/telemetry/telemetry/value/trace_unittest.py b/tools/telemetry/telemetry/value/trace_unittest.py
index d02b2a4..7d747d6 100644
--- a/tools/telemetry/telemetry/value/trace_unittest.py
+++ b/tools/telemetry/telemetry/value/trace_unittest.py
@@ -11,7 +11,6 @@ from telemetry import page as page_module
 from telemetry.page import page_set
 from telemetry.timeline import trace_data
 from telemetry.unittest_util import system_stub
-from telemetry.util import file_handle
 from telemetry.value import trace
 
 
diff --git a/tools/telemetry/telemetry/web_perf/metrics/layout.py b/tools/telemetry/telemetry/web_perf/metrics/layout.py
index 558a9744..617c2fc 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/layout.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/layout.py
@@ -2,7 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import math
 from telemetry.value import list_of_scalar_values
 from telemetry.web_perf.metrics import timeline_based_metric
 
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
index f1108ee..21dc698 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py
@@ -5,7 +5,6 @@
 import os
 import unittest
 
-from telemetry.core import platform
 from telemetry.page import page as page_module
 from telemetry.page import page_set
 from telemetry.results import page_test_results
@@ -14,7 +13,6 @@ from telemetry.timeline import model as model_module
 from telemetry.value import scalar
 from telemetry.web_perf.metrics import timeline_based_metric
 from telemetry.web_perf import timeline_based_measurement as tbm_module
-from telemetry.web_perf import timeline_interaction_record as tir_module
 
 
 class FakeSmoothMetric(timeline_based_metric.TimelineBasedMetric):