diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-26 22:02:14 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-26 22:02:14 +0000 |
| commit | e30e4d816f7e32f2be39f32159e020d3b037de04 (patch) | |
| tree | 7df7110e76599dc6c3a738567986c4a64f0f7a45 /ui/aura/event.h | |
| parent | 19f9aa382283378bb1b6c130511ae6bd873b5453 (diff) | |
| download | chromium_src-e30e4d816f7e32f2be39f32159e020d3b037de04.zip chromium_src-e30e4d816f7e32f2be39f32159e020d3b037de04.tar.gz chromium_src-e30e4d816f7e32f2be39f32159e020d3b037de04.tar.bz2 | |
Classes that implement InfoBarDelegates should contain only what's needed to actually subclass the InfoBarDelegate base classes. If more logic is needed to decide when to show the relevant infobars, then instead of writing a more complex InfoBarDelegate object that is created early and may call AddInfoBar on itself later, split the logic into separate classes, one for the infobar and one for the code that decides when to display the infobar. This is sort of like converting inheritance to composition.
This also does some cleanup, especially on auto_login_prompter.cc, e.g. converting constructors to take classes' direct dependencies, reordering functions to be in the same order in header and .cc file, shorter code, etc.
BUG=96876
TEST=none
Review URL: http://codereview.chromium.org/8042001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102814 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/aura/event.h')
0 files changed, 0 insertions, 0 deletions