diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 02:10:34 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-10 02:10:34 +0000 |
| commit | 12d8cfc27ef90b8dcef76966172f7356555a224b (patch) | |
| tree | e065aeece4e56d46c57a3cef0566c617299846b5 /ui/base/cursor/cursor_loader.h | |
| parent | 15c7e8af4a22221b89edb50601c6893baa418fbc (diff) | |
| download | chromium_src-12d8cfc27ef90b8dcef76966172f7356555a224b.zip chromium_src-12d8cfc27ef90b8dcef76966172f7356555a224b.tar.gz chromium_src-12d8cfc27ef90b8dcef76966172f7356555a224b.tar.bz2 | |
Please discard this CL. Will upload a new one in a bit
Relanding this with fixes for the Win64 builder and addressing jam's comment to move the call to SetCursorResourceModuleName
to chrome_browser_main.cc.
To fix the Win64 builder issues, the SetCursorResourceModuleName function in cursor_loader_win.cc/.h has been wrapped in
a ifdef(USE_AURA) block. As per jam's comment I have moved the call to the SetCursorResourceModuleName function to
ChromeBrowserMainPartsWin::ToolkitInitialized
Make the SetCursorResourceModuleName function in the CursorLoaderWin class a static function and remove it from the
CursorLoader and CursorClient interface. This function is called during browser initialization which prevents race conditions
from reading the cursor module name before it was set.
This ensures that the non standard webkit cursors can be loaded correctly when needed.
Fixes bug https://code.google.com/p/chromium/issues/detail?id=257983
Bug=257983
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/18939004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210717 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/base/cursor/cursor_loader.h')
| -rw-r--r-- | ui/base/cursor/cursor_loader.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/ui/base/cursor/cursor_loader.h b/ui/base/cursor/cursor_loader.h index f8a8a53..d54d298 100644 --- a/ui/base/cursor/cursor_loader.h +++ b/ui/base/cursor/cursor_loader.h @@ -60,10 +60,6 @@ class UI_EXPORT CursorLoader { // Sets the platform cursor based on the native type of |cursor|. virtual void SetPlatformCursor(gfx::NativeCursor* cursor) = 0; - // Used to pass the cursor resource module name to the cursor loader. This is - // typically used to load non system cursors. - virtual void SetCursorResourceModule(const string16& module_name) = 0; - // Creates a CursorLoader. static CursorLoader* Create(); |