diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-02 22:10:56 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-02 22:10:56 +0000 |
| commit | 2fa6318dc46e3be7f998fc1f670bea06fea0e115 (patch) | |
| tree | 2c0ead516c1dd4d7d0ecaab72375d0ba07138049 /ui/base/ime/chromeos/mock_ime_engine_handler.cc | |
| parent | fd2722b12ba5d27d85fd2deec4dd41249f2ec9e6 (diff) | |
| download | chromium_src-2fa6318dc46e3be7f998fc1f670bea06fea0e115.zip chromium_src-2fa6318dc46e3be7f998fc1f670bea06fea0e115.tar.gz chromium_src-2fa6318dc46e3be7f998fc1f670bea06fea0e115.tar.bz2 | |
Final misc. cleanup before landing infobar refactor:
* Minor indenting/wrapping/comment changes
* Remove misplaced standalone "#" (how did this compile?)
* Make definition order match declaration order
* Style guide: Consts come before constructors
* Eliminate unnecessary #if
* Pass MIDIPermissionInfoBarDelegate the necessary |contents_unique_id|; this
matches other infobars and will be necessary after the refactor, since the
InfoBarService will no longer be provided
* Explicitly declare destructors
* MIDIPermissionInfoBarDelegate constructor need not be protected
* EXPECT_TRUE(false) -> ADD_FAILURE()
* Eliminate unnecessary using directives
* Bail out of TranslateInfoBarDelegate::Create() earlier to avoid unnecessary
infobar creation
* Eliminate unnecessary temp
* BrowserWindowControllerTest can just use a SimpleAlertInfoBar instead of
defining its own custom infobar
BUG=none
TEST=none
R=miguelg@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/89443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238203 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/base/ime/chromeos/mock_ime_engine_handler.cc')
0 files changed, 0 insertions, 0 deletions