diff options
| author | spang <spang@chromium.org> | 2015-02-05 07:45:36 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-05 15:46:32 +0000 |
| commit | 2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 (patch) | |
| tree | af0a8cf1ce253892fab0a5b2d2186a5b430a288d /ui/base/ime/input_method_chromeos.h | |
| parent | f6e654986dbda503d573f7551973264219e8fb1f (diff) | |
| download | chromium_src-2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82.zip chromium_src-2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82.tar.gz chromium_src-2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82.tar.bz2 | |
Split ui/base/ime into a new component
The IME code in ui/base/ime depends on ui/ozone to support keyboard
control (via the InputController interface). This dependency is
currently missing from the build.
Unfortunately, we cannot simply add this dependency, because ui/ozone
depends on code from ui/base/cursor and ui/base/resource
(for cursor bitmaps).
Break this cycle by componentizing ui/base/ime & add a dependency
from the new ui/base/ime component to ui/ozone.
This also helps clean things up a bit because iOS builds ui/base
but not ui/base/ime. So there is already a fault line here.
The handful of IME tests are left as part of ui_base_unittests.
BUG=445627
TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' &&
ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes)
TBR=jam
Review URL: https://codereview.chromium.org/889323003
Cr-Commit-Position: refs/heads/master@{#314815}
Diffstat (limited to 'ui/base/ime/input_method_chromeos.h')
| -rw-r--r-- | ui/base/ime/input_method_chromeos.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/base/ime/input_method_chromeos.h b/ui/base/ime/input_method_chromeos.h index 3de4157..f091223 100644 --- a/ui/base/ime/input_method_chromeos.h +++ b/ui/base/ime/input_method_chromeos.h @@ -20,7 +20,7 @@ namespace ui { // A ui::InputMethod implementation based on IBus. -class UI_BASE_EXPORT InputMethodChromeOS +class UI_BASE_IME_EXPORT InputMethodChromeOS : public InputMethodBase, public chromeos::IMEInputContextHandlerInterface { public: |