ui: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=sky@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1730393002

Cr-Commit-Position: refs/heads/master@{#377657}

4 files changed, 8 insertions, 0 deletions

diff --git a/ui/base/x/selection_owner.cc b/ui/base/x/selection_owner.cc
index d13f088d..170f32e 100644
--- a/ui/base/x/selection_owner.cc
+++ b/ui/base/x/selection_owner.cc
@@ -376,6 +376,9 @@ SelectionOwner::IncrementalTransfer::IncrementalTransfer(
       foreign_window_manager_id(foreign_window_manager_id) {
 }
 
+SelectionOwner::IncrementalTransfer::IncrementalTransfer(
+    const IncrementalTransfer& other) = default;
+
 SelectionOwner::IncrementalTransfer::~IncrementalTransfer() {
 }
 
diff --git a/ui/base/x/selection_owner.h b/ui/base/x/selection_owner.h
index f3bec33..6ae933a 100644
--- a/ui/base/x/selection_owner.h
+++ b/ui/base/x/selection_owner.h
@@ -67,6 +67,7 @@ class UI_BASE_EXPORT SelectionOwner {
                         int offset,
                         base::TimeTicks timeout,
                         int foreign_window_manager_id);
+    IncrementalTransfer(const IncrementalTransfer& other);
     ~IncrementalTransfer();
 
     // Parameters from the XSelectionRequest. The data is transferred over
diff --git a/ui/base/x/selection_utils.cc b/ui/base/x/selection_utils.cc
index 7b76e5f..d7acd52 100644
--- a/ui/base/x/selection_utils.cc
+++ b/ui/base/x/selection_utils.cc
@@ -121,6 +121,9 @@ base::string16 RefCountedMemoryToString16(
 
 SelectionFormatMap::SelectionFormatMap() {}
 
+SelectionFormatMap::SelectionFormatMap(const SelectionFormatMap& other) =
+    default;
+
 SelectionFormatMap::~SelectionFormatMap() {}
 
 void SelectionFormatMap::Insert(
diff --git a/ui/base/x/selection_utils.h b/ui/base/x/selection_utils.h
index 1c4bcbd..addbcf7 100644
--- a/ui/base/x/selection_utils.h
+++ b/ui/base/x/selection_utils.h
@@ -66,6 +66,7 @@ class UI_BASE_EXPORT SelectionFormatMap {
   typedef InternalMap::const_iterator const_iterator;
 
   SelectionFormatMap();
+  SelectionFormatMap(const SelectionFormatMap& other);
   ~SelectionFormatMap();
   // Copy and assignment deliberately open.