summaryrefslogtreecommitdiffstats
path: root/ui/base
diff options
context:
space:
mode:
authorben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-24 19:56:00 +0000
committerben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-09-24 19:56:00 +0000
commit521f7e3158beea0ca92b1b26f09185b288d761ba (patch)
tree184af28741f2c18cad21f98d286898757812d9dd /ui/base
parent37d940792d2af2c5e0e880a3abbbfae21e87550c (diff)
downloadchromium_src-521f7e3158beea0ca92b1b26f09185b288d761ba.zip
chromium_src-521f7e3158beea0ca92b1b26f09185b288d761ba.tar.gz
chromium_src-521f7e3158beea0ca92b1b26f09185b288d761ba.tar.bz2
Tighten up DEPS rules in src/ui: prevent components from including from each other, and drop a bunch of DEPS files in to make checkdeps happy.
See https://codereview.chromium.org/24162009/ for try runs. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225020 Review URL: https://codereview.chromium.org/24273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225055 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/base')
-rw-r--r--ui/base/DEPS7
-rw-r--r--ui/base/test/ui_controls_internal_win.cc1
2 files changed, 8 insertions, 0 deletions
diff --git a/ui/base/DEPS b/ui/base/DEPS
new file mode 100644
index 0000000..7a06564
--- /dev/null
+++ b/ui/base/DEPS
@@ -0,0 +1,7 @@
+include_rules = [
+ "+ui/events",
+ "+ui/gfx",
+ "+ui/aura/root_window.h", # TODO(beng): resolve crazy layering violation
+ "+ui/aura/window.h", # TODO(beng): resolve crazy layering violation
+ "+ui/views/view.h", # TODO(beng): resolve crazy layering violation
+]
diff --git a/ui/base/test/ui_controls_internal_win.cc b/ui/base/test/ui_controls_internal_win.cc
index 9e8c17c..2521b98 100644
--- a/ui/base/test/ui_controls_internal_win.cc
+++ b/ui/base/test/ui_controls_internal_win.cc
@@ -12,6 +12,7 @@
#include "ui/events/keycodes/keyboard_code_conversion_win.h"
#include "ui/events/keycodes/keyboard_codes.h"
+// TODO(beng): wtf is this? layering violation!!!1
#if defined(USE_AURA)
#include "ui/aura/root_window.h"
#include "ui/aura/window.h"