diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-29 00:01:31 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-29 00:01:31 +0000 |
| commit | b432dd40c397ce04fb8927a8e834539c850c0f25 (patch) | |
| tree | 70e40d95a8275f75ac2fc5fcf31beeb8e4f6a95c /ui/events/event_dispatcher.h | |
| parent | 4c28dac6b86a458e2f88477707dbeb97a85e5923 (diff) | |
| download | chromium_src-b432dd40c397ce04fb8927a8e834539c850c0f25.zip chromium_src-b432dd40c397ce04fb8927a8e834539c850c0f25.tar.gz chromium_src-b432dd40c397ce04fb8927a8e834539c850c0f25.tar.bz2 | |
Makes tooltips work better with capture
When capture is held all mouse events go to the captured window, even
if another window happens to be under the mouse. This patch makes it
so that when capture is held TooltipController looks for the window
under the mouse and potentially queries it for the tooltip.
If the window under the mouse differs from the captured window it is
queried for the tooltip if the capture window and the window under the
mouse have the same value for the window property
TooltipManager::kGroupingPropertyKey. The only place that sets this
value is menus. When a menu is shown only the first menu has
capture. By picking up the tooltip from the other menus tooltips
show correctly for nested menus.
I also had to update TooltipManagerAura to similarly update the
tooltip on the associated window when capture is held.
BUG=310604 5246 311291
TEST=see bug
R=varunjain@chromium.org
Review URL: https://codereview.chromium.org/40403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231452 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/events/event_dispatcher.h')
| -rw-r--r-- | ui/events/event_dispatcher.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ui/events/event_dispatcher.h b/ui/events/event_dispatcher.h index ef8d6b1..02ad786 100644 --- a/ui/events/event_dispatcher.h +++ b/ui/events/event_dispatcher.h @@ -58,8 +58,7 @@ class EVENTS_EXPORT EventDispatcher { void OnDispatcherDelegateDestroyed(); private: - void DispatchEventToEventHandlers(EventHandlerList& list, - Event* event); + void DispatchEventToEventHandlers(EventHandlerList* list, Event* event); // Dispatches an event, and makes sure it sets ER_CONSUMED on the // event-handling result if the dispatcher itself has been destroyed during |