diff options
| author | kinaba <kinaba@chromium.org> | 2016-02-26 17:14:50 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-27 01:16:28 +0000 |
| commit | 3c315ed174a6f52b8a4a6a58d029fd01c5b5737b (patch) | |
| tree | f16612e5809027f705ab3a7f4dfb220d715cd7ff /ui/file_manager | |
| parent | 062b552bff78b7fc18ad694e28dc9a2173e60006 (diff) | |
| download | chromium_src-3c315ed174a6f52b8a4a6a58d029fd01c5b5737b.zip chromium_src-3c315ed174a6f52b8a4a6a58d029fd01c5b5737b.tar.gz chromium_src-3c315ed174a6f52b8a4a6a58d029fd01c5b5737b.tar.bz2 | |
Fix: condition to hide generic file handlers has to be inverted.
The previous code lists up all handlers when (!!hide == true) which is
essentially when (hide == true). I believe it's not what's intended.
BUG=none
TEST=Install Evernote; "Open with" shows the app.
TEST=Install Evernote; "Choose default" does not show the app.
Review URL: https://codereview.chromium.org/1735203003
Cr-Commit-Position: refs/heads/master@{#378049}
Diffstat (limited to 'ui/file_manager')
| -rw-r--r-- | ui/file_manager/file_manager/foreground/js/file_tasks.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/file_manager/file_manager/foreground/js/file_tasks.js b/ui/file_manager/file_manager/foreground/js/file_tasks.js index a1c2566..1096215 100644 --- a/ui/file_manager/file_manager/foreground/js/file_tasks.js +++ b/ui/file_manager/file_manager/foreground/js/file_tasks.js @@ -827,7 +827,7 @@ FileTasks.prototype.createCombobuttonItem_ = function(task, opt_title, FileTasks.prototype.showTaskPicker = function(taskDialog, title, message, onSuccess, opt_hideGenericFileHandler) { - var items = !!opt_hideGenericFileHandler ? this.createItems_() : + var items = !opt_hideGenericFileHandler ? this.createItems_() : this.createItems_().filter(function(item) { return !item.isGenericFileHandler; }); |