diff options
| author | Mitsuru Oshima <oshima@chromium.org> | 2015-08-03 21:34:25 -0700 |
|---|---|---|
| committer | Mitsuru Oshima <oshima@chromium.org> | 2015-08-04 04:36:24 +0000 |
| commit | 8cb079f8e1ce0efd8a7f0328c3bc6d33807f9470 (patch) | |
| tree | 0c25f3e03be9fa6f92f5c80764fc39efa551ad98 /ui/gfx/paint_vector_icon.h | |
| parent | 48eea5f39c399af026543bfcafc63c9fe55ecfd8 (diff) | |
| download | chromium_src-8cb079f8e1ce0efd8a7f0328c3bc6d33807f9470.zip chromium_src-8cb079f8e1ce0efd8a7f0328c3bc6d33807f9470.tar.gz chromium_src-8cb079f8e1ce0efd8a7f0328c3bc6d33807f9470.tar.bz2 | |
Revert "Make it easier to test changes to a .icon file."
Reason for revert:
build errors on GN bots
LINUX:
FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/views/examples/views_examples_lib/vector_example.o.d .....
../../ui/views/examples/vector_example.cc:112:14:error: no member named 'CreateVectorIconFromSource' in namespace 'gfx'
gfx::CreateVectorIconFromSource(contents, size_, color_));
~~~~~^
1 error generated.
WIN:
[472/771] LINK generate_barcode_video.exe
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/ui/views/examples/views_examples_lib/vector_example.obj.rsp ....
e:\b\build\slave\win_x64_gn\build\src\ui\views\examples\vector_example.cc(112) :error C2039: 'CreateVectorIconFromSource' : is not a member of 'gfx'
e:\b\build\slave\win_x64_gn\build\src\ui\views\examples\vector_example.cc(112) :error C3861: 'CreateVectorIconFromSource': identifier not found
ninja: build stopped: subcommand failed.
> Make it easier to test changes to a .icon file.
> No need to recompile Chrome; views_examples_exe will read from a file. This would also be useful for the tool which will allow de
>
> Since this is potentially unsafe (could crash on the wrong inputs) and doesn't serve a purpose in Chrome itself, it's ifdef'd out
>
> BUG=505953
>
> Review URL: https://codereview.chromium.org/1268633002
>
> Cr-Commit-Position: refs/heads/master@{#341667}
TBR=estade@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1264343003 .
Cr-Commit-Position: refs/heads/master@{#341673}
Diffstat (limited to 'ui/gfx/paint_vector_icon.h')
| -rw-r--r-- | ui/gfx/paint_vector_icon.h | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/ui/gfx/paint_vector_icon.h b/ui/gfx/paint_vector_icon.h index 51b2440..563d7cb 100644 --- a/ui/gfx/paint_vector_icon.h +++ b/ui/gfx/paint_vector_icon.h @@ -28,15 +28,6 @@ GFX_EXPORT ImageSkia CreateVectorIcon(VectorIconId id, size_t dip_size, SkColor color); -#if defined(GFX_VECTOR_ICONS_UNSAFE) || defined(GFX_IMPLEMENTATION) -// Takes a string of the format expected of .icon files and renders onto -// a canvas. This should only be used as a debugging aid and should never be -// used in production code. -GFX_EXPORT ImageSkia CreateVectorIconFromSource(const std::string& source, - size_t dip_size, - SkColor color); -#endif - } // namespace gfx #endif // UI_GFX_PAINT_VECTOR_ICON_H_ |