diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 17:08:17 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 17:08:17 +0000 |
| commit | 3dbc8a684c201efb75f7c18ebe07de4e560c862e (patch) | |
| tree | b932658f33dce5b817f754274330745f596440e1 /ui/gfx/render_text_pango.h | |
| parent | 595fe3fa08135ab7cb711cffc498b3c563a5368a (diff) | |
| download | chromium_src-3dbc8a684c201efb75f7c18ebe07de4e560c862e.zip chromium_src-3dbc8a684c201efb75f7c18ebe07de4e560c862e.tar.gz chromium_src-3dbc8a684c201efb75f7c18ebe07de4e560c862e.tar.bz2 | |
Reland: Fix Views inline autocomplete with multi-char graphemes.
(originally r267752, reverted in r267765 for XP test failures)
(test disabled on XP for a lack of font support, issue 106450)
Allow RenderText selection bounds amid multi-char graphemes.
Add a consolidated IsValidLogicalIndex implementation.
(this is less strict than the renamed IsValidCursorIndex)
Use adjacent cursor positions in MoveCursor as needed.
(prevents invalid cursors when collapsing selections)
Skip painting empty glyph ranges on Windows.
Add a unit test; minor cleanup and comment changes.
BUG=327903,366786,106450
TEST=Search for "จำลอง" in the omnibox; enter "จ" and get a valid selection of the inline autocomplete text.
TBR=asvitkine@chromium.org
Review URL: https://codereview.chromium.org/265903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267826 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/gfx/render_text_pango.h')
| -rw-r--r-- | ui/gfx/render_text_pango.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/gfx/render_text_pango.h b/ui/gfx/render_text_pango.h index ba7361c..4c62e0a 100644 --- a/ui/gfx/render_text_pango.h +++ b/ui/gfx/render_text_pango.h @@ -36,7 +36,7 @@ class RenderTextPango : public RenderText { virtual std::vector<Rect> GetSubstringBounds(const Range& range) OVERRIDE; virtual size_t TextIndexToLayoutIndex(size_t index) const OVERRIDE; virtual size_t LayoutIndexToTextIndex(size_t index) const OVERRIDE; - virtual bool IsCursorablePosition(size_t position) OVERRIDE; + virtual bool IsValidCursorIndex(size_t index) OVERRIDE; virtual void ResetLayout() OVERRIDE; virtual void EnsureLayout() OVERRIDE; virtual void DrawVisualText(Canvas* canvas) OVERRIDE; |