summaryrefslogtreecommitdiffstats
path: root/ui/keyboard
diff options
context:
space:
mode:
authoryukawa@chromium.org <yukawa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-22 01:44:39 +0000
committeryukawa@chromium.org <yukawa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-22 01:44:39 +0000
commitcf6cc2ee0f6a8267d5246f490421ac39b40f5b1c (patch)
treea8e3dae80b8783ab160c4337af91783359994ce4 /ui/keyboard
parentf67e18a5392f142f6d85e880c060ef5838f6bec2 (diff)
downloadchromium_src-cf6cc2ee0f6a8267d5246f490421ac39b40f5b1c.zip
chromium_src-cf6cc2ee0f6a8267d5246f490421ac39b40f5b1c.tar.gz
chromium_src-cf6cc2ee0f6a8267d5246f490421ac39b40f5b1c.tar.bz2
Mark getter methods in ui::InputMethod as const
This CL marks following methods as "const-method" as a preparation to fix issue 164964. - ui::TextInputClient::GetCaretBounds - ui::TextInputClient::GetCompositionCharacterBounds - ui::TextInputClient::HasCompositionText - ui::TextInputClient::GetTextRange - ui::TextInputClient::GetCompositionTextRang - ui::TextInputClient::GetSelectionRange - ui::TextInputClient::GetTextFromRange BUG=164964 TEST=none Review URL: https://codereview.chromium.org/27812003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230001 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/keyboard')
-rw-r--r--ui/keyboard/keyboard_controller_unittest.cc19
1 files changed, 11 insertions, 8 deletions
diff --git a/ui/keyboard/keyboard_controller_unittest.cc b/ui/keyboard/keyboard_controller_unittest.cc
index 3650520..407cc6a 100644
--- a/ui/keyboard/keyboard_controller_unittest.cc
+++ b/ui/keyboard/keyboard_controller_unittest.cc
@@ -128,24 +128,27 @@ class TestTextInputClient : public ui::TextInputClient {
return ui::TEXT_INPUT_MODE_DEFAULT;
}
virtual bool CanComposeInline() const OVERRIDE { return false; }
- virtual gfx::Rect GetCaretBounds() OVERRIDE { return gfx::Rect(); }
+ virtual gfx::Rect GetCaretBounds() const OVERRIDE { return gfx::Rect(); }
- virtual bool GetCompositionCharacterBounds(uint32 index,
- gfx::Rect* rect) OVERRIDE {
+ virtual bool GetCompositionCharacterBounds(
+ uint32 index,
+ gfx::Rect* rect) const OVERRIDE {
return false;
}
- virtual bool HasCompositionText() OVERRIDE { return false; }
- virtual bool GetTextRange(gfx::Range* range) OVERRIDE { return false; }
- virtual bool GetCompositionTextRange(gfx::Range* range) OVERRIDE {
+ virtual bool HasCompositionText() const OVERRIDE { return false; }
+ virtual bool GetTextRange(gfx::Range* range) const OVERRIDE { return false; }
+ virtual bool GetCompositionTextRange(gfx::Range* range) const OVERRIDE {
+ return false;
+ }
+ virtual bool GetSelectionRange(gfx::Range* range) const OVERRIDE {
return false;
}
- virtual bool GetSelectionRange(gfx::Range* range) OVERRIDE { return false; }
virtual bool SetSelectionRange(const gfx::Range& range) OVERRIDE {
return false;
}
virtual bool DeleteRange(const gfx::Range& range) OVERRIDE { return false; }
virtual bool GetTextFromRange(const gfx::Range& range,
- base::string16* text) OVERRIDE {
+ base::string16* text) const OVERRIDE {
return false;
}
virtual void OnInputMethodChanged() OVERRIDE {}