diff options
| author | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 10:53:03 +0000 |
|---|---|---|
| committer | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 10:53:03 +0000 |
| commit | 8f1eecc70360f7369de1006f043dfdac04694fec (patch) | |
| tree | d9270684436c2ff5c6f5e0f9c44718becf74f7f4 /ui/message_center | |
| parent | 295a6d6b5b54a8c3007b415dd82d3bd5b2f5c7de (diff) | |
| download | chromium_src-8f1eecc70360f7369de1006f043dfdac04694fec.zip chromium_src-8f1eecc70360f7369de1006f043dfdac04694fec.tar.gz chromium_src-8f1eecc70360f7369de1006f043dfdac04694fec.tar.bz2 | |
Fix the crash bug of new popup.
I was wrong, at any code point, CloseAllWidgets() doesn't need to
mark the notifications as shown in popup. This method is called when
the popup notifications are empty or it's destroyed, and the dtor
happens for HidePopup() which is actually invoked for deleting
notifications.
BUG=178942
TEST=do the repro steps on the bug on goobuntu
Review URL: https://chromiumcodereview.appspot.com/12389007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185217 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/message_center')
| -rw-r--r-- | ui/message_center/message_popup_collection.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/message_center/message_popup_collection.cc b/ui/message_center/message_popup_collection.cc index 17b884b..7ffa609 100644 --- a/ui/message_center/message_popup_collection.cc +++ b/ui/message_center/message_popup_collection.cc @@ -221,8 +221,6 @@ void MessagePopupCollection::CloseAllWidgets() { for (ToastContainer::iterator iter = toasts_.begin(); iter != toasts_.end(); ++iter) { iter->second->SuspendTimer(); - list_delegate_->GetNotificationList()->MarkSinglePopupAsShown( - iter->first, false); views::Widget* widget = iter->second->GetWidget(); widget->RemoveObserver(this); widget->Close(); |