diff options
author | brettw <brettw@chromium.org> | 2015-12-07 17:29:21 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-08 01:30:15 +0000 |
commit | b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa (patch) | |
tree | eed9bb2007568cff2f485d2424a92bf5f95d15dc /ui/mojo | |
parent | 6a1950a5a0a7f80a7e1815656cf0296df363dc52 (diff) | |
download | chromium_src-b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa.zip chromium_src-b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa.tar.gz chromium_src-b7f2c30e4cc7b6c25e348c848af92d173dd3cbaa.tar.bz2 |
Add most of //ui/ to "gn check"
Fixes various missing dependencies.
In static builds, the //content target now exports content/public/browser, etc. as public dependencies.
Add an ipc_param_traits target that allows targets like events/latency_info.h to define IPC traits, without actually linking in all of IPC (because in this case events has no use of IPC).
Move some targets to public deps. The rule is that test_support targets should export the corresponding regular target as a public dep so tests don't have to depend on both.
Mark a few conditional includes "// nogncheck" where the checker got confused.
Fix manifest for views_unittests
Review URL: https://codereview.chromium.org/1501823003
Cr-Commit-Position: refs/heads/master@{#363690}
Diffstat (limited to 'ui/mojo')
-rw-r--r-- | ui/mojo/geometry/BUILD.gn | 4 | ||||
-rw-r--r-- | ui/mojo/init/BUILD.gn | 6 | ||||
-rw-r--r-- | ui/mojo/init/ui_init.cc | 2 |
3 files changed, 7 insertions, 5 deletions
diff --git a/ui/mojo/geometry/BUILD.gn b/ui/mojo/geometry/BUILD.gn index f39fa04..b44586d 100644 --- a/ui/mojo/geometry/BUILD.gn +++ b/ui/mojo/geometry/BUILD.gn @@ -14,4 +14,8 @@ source_set("util") { sources = [ "geometry_util.h", ] + + deps = [ + ":interfaces", + ] } diff --git a/ui/mojo/init/BUILD.gn b/ui/mojo/init/BUILD.gn index e6745ad..e22242ad 100644 --- a/ui/mojo/init/BUILD.gn +++ b/ui/mojo/init/BUILD.gn @@ -12,13 +12,11 @@ source_set("init") { deps = [ "//base", + "//ui/gfx", "//ui/gfx/geometry", ] if (is_android) { - deps += [ - "//ui/events:gesture_detection", - "//ui/gfx", - ] + deps += [ "//ui/events:gesture_detection" ] } } diff --git a/ui/mojo/init/ui_init.cc b/ui/mojo/init/ui_init.cc index 3b4c4ab..d4e8f27 100644 --- a/ui/mojo/init/ui_init.cc +++ b/ui/mojo/init/ui_init.cc @@ -8,7 +8,7 @@ #include "ui/mojo/init/screen_mojo.h" #if defined(OS_ANDROID) -#include "ui/events/gesture_detection/gesture_configuration.h" +#include "ui/events/gesture_detection/gesture_configuration.h" // nogncheck #endif namespace ui { |