diff options
| author | brettw <brettw@chromium.org> | 2014-10-09 15:40:53 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-09 22:41:19 +0000 |
| commit | f9fe3305fc6097e26db01b4b38e362160b0d4679 (patch) | |
| tree | d58c3977ab60eb317c7bff6d55692d189b759193 /ui/platform_window | |
| parent | 8ea251ca5220a7875f9d50a583575b07522d478c (diff) | |
| download | chromium_src-f9fe3305fc6097e26db01b4b38e362160b0d4679.zip chromium_src-f9fe3305fc6097e26db01b4b38e362160b0d4679.tar.gz chromium_src-f9fe3305fc6097e26db01b4b38e362160b0d4679.tar.bz2 | |
Revert of Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/647573002/)
Reason for revert:
This was not the cause of the regression. See http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6569
Original issue's description:
> Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/)
>
> Reason for revert:
> Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures.
>
> Original issue's description:
> > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed
> >
> > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run.
> >
> > BUG=421536
> >
> > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c
> > Cr-Commit-Position: refs/heads/master@{#298926}
>
> TBR=ben@chromium.org,hansmuller@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=421536
>
> Committed: https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542
> Cr-Commit-Position: refs/heads/master@{#298985}
TBR=ben@chromium.org,hansmuller@chromium.org,jwd@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421536
Review URL: https://codereview.chromium.org/642953003
Cr-Commit-Position: refs/heads/master@{#298999}
Diffstat (limited to 'ui/platform_window')
| -rw-r--r-- | ui/platform_window/x11/x11_window.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/platform_window/x11/x11_window.cc b/ui/platform_window/x11/x11_window.cc index 07baea6..e3a421c 100644 --- a/ui/platform_window/x11/x11_window.cc +++ b/ui/platform_window/x11/x11_window.cc @@ -56,6 +56,7 @@ X11Window::~X11Window() { } void X11Window::Destroy() { + delegate_->OnClosed(); if (xwindow_ == None) return; |