diff options
author | mostynb <mostynb@opera.com> | 2014-10-09 03:54:27 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-09 10:55:07 +0000 |
commit | 3b3d52b1844d5174f63a1db8cf3f0e3254ec43f6 (patch) | |
tree | 720b6c8d126123e087abffedaedd8a9fa4907132 /ui/views/bubble | |
parent | 002d02909368b7067cc3df9149c5e46ce445861c (diff) | |
download | chromium_src-3b3d52b1844d5174f63a1db8cf3f0e3254ec43f6.zip chromium_src-3b3d52b1844d5174f63a1db8cf3f0e3254ec43f6.tar.gz chromium_src-3b3d52b1844d5174f63a1db8cf3f0e3254ec43f6.tar.bz2 |
replace OVERRIDE and FINAL with override and final in ui/
BUG=417463
Review URL: https://codereview.chromium.org/623293004
Cr-Commit-Position: refs/heads/master@{#298839}
Diffstat (limited to 'ui/views/bubble')
-rw-r--r-- | ui/views/bubble/bubble_border.h | 8 | ||||
-rw-r--r-- | ui/views/bubble/bubble_delegate.h | 24 | ||||
-rw-r--r-- | ui/views/bubble/bubble_delegate_unittest.cc | 4 | ||||
-rw-r--r-- | ui/views/bubble/bubble_frame_view.h | 34 | ||||
-rw-r--r-- | ui/views/bubble/bubble_frame_view_unittest.cc | 2 | ||||
-rw-r--r-- | ui/views/bubble/bubble_window_targeter.h | 2 | ||||
-rw-r--r-- | ui/views/bubble/bubble_window_targeter_unittest.cc | 6 | ||||
-rw-r--r-- | ui/views/bubble/tray_bubble_view.cc | 14 | ||||
-rw-r--r-- | ui/views/bubble/tray_bubble_view.h | 30 |
9 files changed, 62 insertions, 62 deletions
diff --git a/ui/views/bubble/bubble_border.h b/ui/views/bubble/bubble_border.h index 8ce546a..8fc149b 100644 --- a/ui/views/bubble/bubble_border.h +++ b/ui/views/bubble/bubble_border.h @@ -196,9 +196,9 @@ class VIEWS_EXPORT BubbleBorder : public Border { int GetArrowOffset(const gfx::Size& border_size) const; // Overridden from Border: - virtual void Paint(const View& view, gfx::Canvas* canvas) OVERRIDE; - virtual gfx::Insets GetInsets() const OVERRIDE; - virtual gfx::Size GetMinimumSize() const OVERRIDE; + virtual void Paint(const View& view, gfx::Canvas* canvas) override; + virtual gfx::Insets GetInsets() const override; + virtual gfx::Size GetMinimumSize() const override; private: FRIEND_TEST_ALL_PREFIXES(BubbleBorderTest, GetSizeForContentsSizeTest); @@ -233,7 +233,7 @@ class VIEWS_EXPORT BubbleBackground : public Background { explicit BubbleBackground(BubbleBorder* border) : border_(border) {} // Overridden from Background: - virtual void Paint(gfx::Canvas* canvas, View* view) const OVERRIDE; + virtual void Paint(gfx::Canvas* canvas, View* view) const override; private: BubbleBorder* border_; diff --git a/ui/views/bubble/bubble_delegate.h b/ui/views/bubble/bubble_delegate.h index 739ec92..5f21313 100644 --- a/ui/views/bubble/bubble_delegate.h +++ b/ui/views/bubble/bubble_delegate.h @@ -33,21 +33,21 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView, static Widget* CreateBubble(BubbleDelegateView* bubble_delegate); // WidgetDelegateView overrides: - virtual BubbleDelegateView* AsBubbleDelegate() OVERRIDE; - virtual bool ShouldShowCloseButton() const OVERRIDE; - virtual View* GetContentsView() OVERRIDE; - virtual NonClientFrameView* CreateNonClientFrameView(Widget* widget) OVERRIDE; - virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE; + virtual BubbleDelegateView* AsBubbleDelegate() override; + virtual bool ShouldShowCloseButton() const override; + virtual View* GetContentsView() override; + virtual NonClientFrameView* CreateNonClientFrameView(Widget* widget) override; + virtual void GetAccessibleState(ui::AXViewState* state) override; // WidgetObserver overrides: - virtual void OnWidgetDestroying(Widget* widget) OVERRIDE; + virtual void OnWidgetDestroying(Widget* widget) override; virtual void OnWidgetVisibilityChanging(Widget* widget, bool visible) - OVERRIDE; + override; virtual void OnWidgetVisibilityChanged(Widget* widget, bool visible) - OVERRIDE; - virtual void OnWidgetActivationChanged(Widget* widget, bool active) OVERRIDE; + override; + virtual void OnWidgetActivationChanged(Widget* widget, bool active) override; virtual void OnWidgetBoundsChanged(Widget* widget, - const gfx::Rect& new_bounds) OVERRIDE; + const gfx::Rect& new_bounds) override; bool close_on_esc() const { return close_on_esc_; } void set_close_on_esc(bool close_on_esc) { close_on_esc_ = close_on_esc; } @@ -119,8 +119,8 @@ class VIEWS_EXPORT BubbleDelegateView : public WidgetDelegateView, virtual const gfx::FontList& GetTitleFontList() const; // View overrides: - virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) OVERRIDE; - virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE; + virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) override; + virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) override; // Perform view initialization on the contents for bubble sizing. virtual void Init(); diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc index a0cd57b..c3ba170 100644 --- a/ui/views/bubble/bubble_delegate_unittest.cc +++ b/ui/views/bubble/bubble_delegate_unittest.cc @@ -33,8 +33,8 @@ class TestBubbleDelegateView : public BubbleDelegateView { } // BubbleDelegateView overrides: - virtual View* GetInitiallyFocusedView() OVERRIDE { return view_; } - virtual gfx::Size GetPreferredSize() const OVERRIDE { + virtual View* GetInitiallyFocusedView() override { return view_; } + virtual gfx::Size GetPreferredSize() const override { return gfx::Size(200, 200); } diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h index f14ca1e..1d3add7 100644 --- a/ui/views/bubble/bubble_frame_view.h +++ b/ui/views/bubble/bubble_frame_view.h @@ -40,33 +40,33 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView, static LabelButton* CreateCloseButton(ButtonListener* listener); // NonClientFrameView overrides: - virtual gfx::Rect GetBoundsForClientView() const OVERRIDE; + virtual gfx::Rect GetBoundsForClientView() const override; virtual gfx::Rect GetWindowBoundsForClientBounds( - const gfx::Rect& client_bounds) const OVERRIDE; - virtual int NonClientHitTest(const gfx::Point& point) OVERRIDE; + const gfx::Rect& client_bounds) const override; + virtual int NonClientHitTest(const gfx::Point& point) override; virtual void GetWindowMask(const gfx::Size& size, - gfx::Path* window_mask) OVERRIDE; - virtual void ResetWindowControls() OVERRIDE; - virtual void UpdateWindowIcon() OVERRIDE; - virtual void UpdateWindowTitle() OVERRIDE; - virtual void SizeConstraintsChanged() OVERRIDE; + gfx::Path* window_mask) override; + virtual void ResetWindowControls() override; + virtual void UpdateWindowIcon() override; + virtual void UpdateWindowTitle() override; + virtual void SizeConstraintsChanged() override; // Set the FontList to be used for the title of the bubble. // Caller must arrange to update the layout to have the call take effect. void SetTitleFontList(const gfx::FontList& font_list); // View overrides: - virtual gfx::Insets GetInsets() const OVERRIDE; - virtual gfx::Size GetPreferredSize() const OVERRIDE; - virtual gfx::Size GetMinimumSize() const OVERRIDE; - virtual void Layout() OVERRIDE; - virtual const char* GetClassName() const OVERRIDE; - virtual void ChildPreferredSizeChanged(View* child) OVERRIDE; - virtual void OnThemeChanged() OVERRIDE; - virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) OVERRIDE; + virtual gfx::Insets GetInsets() const override; + virtual gfx::Size GetPreferredSize() const override; + virtual gfx::Size GetMinimumSize() const override; + virtual void Layout() override; + virtual const char* GetClassName() const override; + virtual void ChildPreferredSizeChanged(View* child) override; + virtual void OnThemeChanged() override; + virtual void OnNativeThemeChanged(const ui::NativeTheme* theme) override; // Overridden from ButtonListener: - virtual void ButtonPressed(Button* sender, const ui::Event& event) OVERRIDE; + virtual void ButtonPressed(Button* sender, const ui::Event& event) override; // Use bubble_border() and SetBubbleBorder(), not border() and SetBorder(). BubbleBorder* bubble_border() const { return bubble_border_; } diff --git a/ui/views/bubble/bubble_frame_view_unittest.cc b/ui/views/bubble/bubble_frame_view_unittest.cc index 1bd9e34..545ca38 100644 --- a/ui/views/bubble/bubble_frame_view_unittest.cc +++ b/ui/views/bubble/bubble_frame_view_unittest.cc @@ -29,7 +29,7 @@ class TestBubbleFrameView : public BubbleFrameView { virtual ~TestBubbleFrameView() {} // BubbleFrameView overrides: - virtual gfx::Rect GetAvailableScreenBounds(const gfx::Rect& rect) OVERRIDE { + virtual gfx::Rect GetAvailableScreenBounds(const gfx::Rect& rect) override { return available_bounds_; } diff --git a/ui/views/bubble/bubble_window_targeter.h b/ui/views/bubble/bubble_window_targeter.h index 45b1d5c..b37eaa0 100644 --- a/ui/views/bubble/bubble_window_targeter.h +++ b/ui/views/bubble/bubble_window_targeter.h @@ -23,7 +23,7 @@ class VIEWS_EXPORT BubbleWindowTargeter private: // wm::MaskedWindowTargeter: virtual bool GetHitTestMask(aura::Window* window, - gfx::Path* mask) const OVERRIDE; + gfx::Path* mask) const override; views::BubbleDelegateView* bubble_; diff --git a/ui/views/bubble/bubble_window_targeter_unittest.cc b/ui/views/bubble/bubble_window_targeter_unittest.cc index 479f6e9..4ff0e0a 100644 --- a/ui/views/bubble/bubble_window_targeter_unittest.cc +++ b/ui/views/bubble/bubble_window_targeter_unittest.cc @@ -26,7 +26,7 @@ class WidgetOwnsNativeBubble : public BubbleDelegateView { private: // BubbleDelegateView: virtual void OnBeforeBubbleWidgetInit(Widget::InitParams* params, - Widget* widget) const OVERRIDE { + Widget* widget) const override { params->ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; } @@ -42,7 +42,7 @@ class BubbleWindowTargeterTest : public ViewsTestBase { } virtual ~BubbleWindowTargeterTest() {} - virtual void SetUp() OVERRIDE { + virtual void SetUp() override { ViewsTestBase::SetUp(); CreateAnchorWidget(); CreateBubbleWidget(); @@ -51,7 +51,7 @@ class BubbleWindowTargeterTest : public ViewsTestBase { bubble_widget()->Show(); } - virtual void TearDown() OVERRIDE { + virtual void TearDown() override { bubble_delegate_ = NULL; bubble_widget_.reset(); anchor_.reset(); diff --git a/ui/views/bubble/tray_bubble_view.cc b/ui/views/bubble/tray_bubble_view.cc index d1cf48e..53cb526 100644 --- a/ui/views/bubble/tray_bubble_view.cc +++ b/ui/views/bubble/tray_bubble_view.cc @@ -56,7 +56,7 @@ class MouseMoveDetectorHost : public MouseWatcherHost { virtual ~MouseMoveDetectorHost(); virtual bool Contains(const gfx::Point& screen_point, - MouseEventType type) OVERRIDE; + MouseEventType type) override; private: DISALLOW_COPY_AND_ASSIGN(MouseMoveDetectorHost); }; @@ -94,7 +94,7 @@ class TrayBubbleBorder : public BubbleBorder { // Overridden from BubbleBorder. // Sets the bubble on top of the anchor when it has no arrow. virtual gfx::Rect GetBounds(const gfx::Rect& position_relative_to, - const gfx::Size& contents_size) const OVERRIDE { + const gfx::Size& contents_size) const override { if (has_arrow(arrow())) { gfx::Rect rect = BubbleBorder::GetBounds(position_relative_to, contents_size); @@ -182,11 +182,11 @@ class TrayBubbleContentMask : public ui::LayerDelegate { ui::Layer* layer() { return &layer_; } // Overridden from LayerDelegate. - virtual void OnPaintLayer(gfx::Canvas* canvas) OVERRIDE; + virtual void OnPaintLayer(gfx::Canvas* canvas) override; virtual void OnDelegatedFrameDamage( - const gfx::Rect& damage_rect_in_dip) OVERRIDE {} - virtual void OnDeviceScaleFactorChanged(float device_scale_factor) OVERRIDE; - virtual base::Closure PrepareForLayerBoundsChange() OVERRIDE; + const gfx::Rect& damage_rect_in_dip) override {} + virtual void OnDeviceScaleFactorChanged(float device_scale_factor) override; + virtual base::Closure PrepareForLayerBoundsChange() override; private: ui::Layer layer_; @@ -234,7 +234,7 @@ class BottomAlignedBoxLayout : public BoxLayout { virtual ~BottomAlignedBoxLayout() {} private: - virtual void Layout(View* host) OVERRIDE { + virtual void Layout(View* host) override { if (host->height() >= host->GetPreferredSize().height() || !bubble_view_->is_gesture_dragging()) { BoxLayout::Layout(host); diff --git a/ui/views/bubble/tray_bubble_view.h b/ui/views/bubble/tray_bubble_view.h index 54f6cc8..8ffd58d 100644 --- a/ui/views/bubble/tray_bubble_view.h +++ b/ui/views/bubble/tray_bubble_view.h @@ -147,25 +147,25 @@ class VIEWS_EXPORT TrayBubbleView : public views::BubbleDelegateView, bool is_gesture_dragging() const { return is_gesture_dragging_; } // Overridden from views::WidgetDelegate. - virtual bool CanActivate() const OVERRIDE; + virtual bool CanActivate() const override; virtual views::NonClientFrameView* CreateNonClientFrameView( - views::Widget* widget) OVERRIDE; - virtual bool WidgetHasHitTestMask() const OVERRIDE; - virtual void GetWidgetHitTestMask(gfx::Path* mask) const OVERRIDE; + views::Widget* widget) override; + virtual bool WidgetHasHitTestMask() const override; + virtual void GetWidgetHitTestMask(gfx::Path* mask) const override; // Overridden from views::BubbleDelegateView. - virtual gfx::Rect GetAnchorRect() const OVERRIDE; + virtual gfx::Rect GetAnchorRect() const override; // Overridden from views::View. - virtual gfx::Size GetPreferredSize() const OVERRIDE; - virtual gfx::Size GetMaximumSize() const OVERRIDE; - virtual int GetHeightForWidth(int width) const OVERRIDE; - virtual void OnMouseEntered(const ui::MouseEvent& event) OVERRIDE; - virtual void OnMouseExited(const ui::MouseEvent& event) OVERRIDE; - virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE; + virtual gfx::Size GetPreferredSize() const override; + virtual gfx::Size GetMaximumSize() const override; + virtual int GetHeightForWidth(int width) const override; + virtual void OnMouseEntered(const ui::MouseEvent& event) override; + virtual void OnMouseExited(const ui::MouseEvent& event) override; + virtual void GetAccessibleState(ui::AXViewState* state) override; // Overridden from MouseWatcherListener - virtual void MouseMovedOutOfHost() OVERRIDE; + virtual void MouseMovedOutOfHost() override; protected: TrayBubbleView(gfx::NativeView parent_window, @@ -174,12 +174,12 @@ class VIEWS_EXPORT TrayBubbleView : public views::BubbleDelegateView, const InitParams& init_params); // Overridden from views::BubbleDelegateView. - virtual void Init() OVERRIDE; + virtual void Init() override; // Overridden from views::View. - virtual void ChildPreferredSizeChanged(View* child) OVERRIDE; + virtual void ChildPreferredSizeChanged(View* child) override; virtual void ViewHierarchyChanged( - const ViewHierarchyChangedDetails& details) OVERRIDE; + const ViewHierarchyChangedDetails& details) override; private: InitParams params_; |