diff options
author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-02 21:24:22 +0000 |
---|---|---|
committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-02 21:24:22 +0000 |
commit | 72fc4b91fd45c00004a69790b59ba4917ba117ed (patch) | |
tree | 908a0e34be29a3206f88cac0064d43ec00db7ab9 /ui/views/events | |
parent | d89ff811f8c0e5033a38273979d6b367ed057b0e (diff) | |
download | chromium_src-72fc4b91fd45c00004a69790b59ba4917ba117ed.zip chromium_src-72fc4b91fd45c00004a69790b59ba4917ba117ed.tar.gz chromium_src-72fc4b91fd45c00004a69790b59ba4917ba117ed.tar.bz2 |
Copy more focus manager into V2. Comment out a bunch of stuff and add stub impls of methods with TODOs so that it builds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6334062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73513 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ui/views/events')
-rw-r--r-- | ui/views/events/accelerator.cc | 179 | ||||
-rw-r--r-- | ui/views/events/accelerator.h | 32 | ||||
-rw-r--r-- | ui/views/events/event.cc | 13 | ||||
-rw-r--r-- | ui/views/events/event.h | 4 |
4 files changed, 228 insertions, 0 deletions
diff --git a/ui/views/events/accelerator.cc b/ui/views/events/accelerator.cc new file mode 100644 index 0000000..582c3a3 --- /dev/null +++ b/ui/views/events/accelerator.cc @@ -0,0 +1,179 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "ui/views/events/accelerator.h" + +#if defined(OS_WIN) +#include <windows.h> +#elif defined(OS_LINUX) +#include <gdk/gdk.h> +#endif + +#include "base/i18n/rtl.h" +#include "base/logging.h" +#include "base/string_util.h" +#include "base/utf_string_conversions.h" +#include "grit/app_strings.h" +#include "ui/base/l10n/l10n_util.h" + +namespace ui { + +namespace { + +bool IsShiftDown(const Accelerator& accelerator) { + return (accelerator.GetKeyCode() & VKEY_SHIFT) == VKEY_SHIFT; +} + +bool IsCtrlDown(const Accelerator& accelerator) { + return (accelerator.GetKeyCode() & VKEY_CONTROL) == VKEY_CONTROL; +} + +bool IsAltDown(const Accelerator& accelerator) { + return (accelerator.GetKeyCode() & VKEY_MENU) == VKEY_MENU; +} + +} // namespace + +string16 GetShortcutTextForAccelerator(const Accelerator& accelerator) { + int string_id = 0; + switch(accelerator.GetKeyCode()) { + case ui::VKEY_TAB: + string_id = IDS_APP_TAB_KEY; + break; + case ui::VKEY_RETURN: + string_id = IDS_APP_ENTER_KEY; + break; + case ui::VKEY_ESCAPE: + string_id = IDS_APP_ESC_KEY; + break; + case ui::VKEY_PRIOR: + string_id = IDS_APP_PAGEUP_KEY; + break; + case ui::VKEY_NEXT: + string_id = IDS_APP_PAGEDOWN_KEY; + break; + case ui::VKEY_END: + string_id = IDS_APP_END_KEY; + break; + case ui::VKEY_HOME: + string_id = IDS_APP_HOME_KEY; + break; + case ui::VKEY_INSERT: + string_id = IDS_APP_INSERT_KEY; + break; + case ui::VKEY_DELETE: + string_id = IDS_APP_DELETE_KEY; + break; + case ui::VKEY_LEFT: + string_id = IDS_APP_LEFT_ARROW_KEY; + break; + case ui::VKEY_RIGHT: + string_id = IDS_APP_RIGHT_ARROW_KEY; + break; + case ui::VKEY_BACK: + string_id = IDS_APP_BACKSPACE_KEY; + break; + case ui::VKEY_F1: + string_id = IDS_APP_F1_KEY; + break; + case ui::VKEY_F11: + string_id = IDS_APP_F11_KEY; + break; + default: + break; + } + + string16 shortcut; + if (!string_id) { +#if defined(OS_WIN) + // Our fallback is to try translate the key code to a regular character + // unless it is one of digits (VK_0 to VK_9). Some keyboard + // layouts have characters other than digits assigned in + // an unshifted mode (e.g. French AZERY layout has 'a with grave + // accent' for '0'). For display in the menu (e.g. Ctrl-0 for the + // default zoom level), we leave VK_[0-9] alone without translation. + wchar_t key; + if (accelerator.GetKeyCode() >= '0' && accelerator.GetKeyCode() <= '9') + key = accelerator.GetKeyCode(); + else + key = LOWORD(::MapVirtualKeyW(accelerator.GetKeyCode(), MAPVK_VK_TO_CHAR)); + shortcut += key; +#elif defined(OS_LINUX) + const gchar* name = NULL; + switch (accelerator.GetKeyCode()) { + case ui::VKEY_OEM_2: + name = static_cast<const gchar*>("/"); + break; + default: + name = gdk_keyval_name(gdk_keyval_to_lower(accelerator.GetKeyCode())); + break; + } + if (name) { + if (name[0] != 0 && name[1] == 0) + shortcut += static_cast<string16::value_type>(g_ascii_toupper(name[0])); + else + shortcut += UTF8ToUTF16(name); + } +#endif + } else { + shortcut = l10n_util::GetStringUTF16(string_id); + } + + // Checking whether the character used for the accelerator is alphanumeric. + // If it is not, then we need to adjust the string later on if the locale is + // right-to-left. See below for more information of why such adjustment is + // required. + string16 shortcut_rtl; + bool adjust_shortcut_for_rtl = false; + if (base::i18n::IsRTL() && shortcut.length() == 1 && + !IsAsciiAlpha(shortcut.at(0)) && !IsAsciiDigit(shortcut.at(0))) { + adjust_shortcut_for_rtl = true; + shortcut_rtl.assign(shortcut); + } + + if (IsShiftDown(accelerator)) + shortcut = l10n_util::GetStringFUTF16(IDS_APP_SHIFT_MODIFIER, shortcut); + + // Note that we use 'else-if' in order to avoid using Ctrl+Alt as a shortcut. + // See http://blogs.msdn.com/oldnewthing/archive/2004/03/29/101121.aspx for + // more information. + if (IsCtrlDown(accelerator)) + shortcut = l10n_util::GetStringFUTF16(IDS_APP_CONTROL_MODIFIER, shortcut); + else if (IsAltDown(accelerator)) + shortcut = l10n_util::GetStringFUTF16(IDS_APP_ALT_MODIFIER, shortcut); + + // For some reason, menus in Windows ignore standard Unicode directionality + // marks (such as LRE, PDF, etc.). On RTL locales, we use RTL menus and + // therefore any text we draw for the menu items is drawn in an RTL context. + // Thus, the text "Ctrl++" (which we currently use for the Zoom In option) + // appears as "++Ctrl" in RTL because the Unicode BiDi algorithm puts + // punctuations on the left when the context is right-to-left. Shortcuts that + // do not end with a punctuation mark (such as "Ctrl+H" do not have this + // problem). + // + // The only way to solve this problem is to adjust the string if the locale + // is RTL so that it is drawn correnctly in an RTL context. Instead of + // returning "Ctrl++" in the above example, we return "++Ctrl". This will + // cause the text to appear as "Ctrl++" when Windows draws the string in an + // RTL context because the punctunation no longer appears at the end of the + // string. + // + // TODO(idana) bug# 1232732: this hack can be avoided if instead of using + // views::Menu we use views::MenuItemView because the latter is a View + // subclass and therefore it supports marking text as RTL or LTR using + // standard Unicode directionality marks. + if (adjust_shortcut_for_rtl) { + int key_length = static_cast<int>(shortcut_rtl.length()); + DCHECK_GT(key_length, 0); + shortcut_rtl.append(ASCIIToUTF16("+")); + + // Subtracting the size of the shortcut key and 1 for the '+' sign. + shortcut_rtl.append(shortcut, 0, shortcut.length() - key_length - 1); + shortcut.swap(shortcut_rtl); + } + + return shortcut; +} + +} // namespace ui diff --git a/ui/views/events/accelerator.h b/ui/views/events/accelerator.h new file mode 100644 index 0000000..c75d73d --- /dev/null +++ b/ui/views/events/accelerator.h @@ -0,0 +1,32 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef UI_VIEWS_EVENTS_ACCELERATOR_H_ +#define UI_VIEWS_EVENTS_ACCELERATOR_H_ +#pragma once + +#include <string> + +#include "base/string16.h" +#include "ui/base/models/accelerator.h" +#include "ui/views/events/event.h" + +namespace ui { + +string16 GetShortcutTextForAccelerator(const Accelerator& accelerator); + +// An interface that classes that want to register for keyboard accelerators +// should implement. +class AcceleratorTarget { + public: + // This method should return true if the accelerator was processed. + virtual bool AcceleratorPressed(const Accelerator& accelerator) = 0; + + protected: + virtual ~AcceleratorTarget() {} +}; + +} // namespace ui + +#endif // UI_VIEWS_EVENTS_ACCELERATOR_H_ diff --git a/ui/views/events/event.cc b/ui/views/events/event.cc index 4c62b8a..f1d04b9 100644 --- a/ui/views/events/event.cc +++ b/ui/views/events/event.cc @@ -16,6 +16,19 @@ Event::Event(EventType type, int flags) flags_(flags) { } +int Event::GetModifiers() const { + int modifiers = 0; + if (IsShiftDown()) + modifiers |= VKEY_SHIFT; + if (IsControlDown()) + modifiers |= VKEY_CONTROL; + if (IsAltDown()) + modifiers |= VKEY_MENU; + if (IsCapsLockDown()) + modifiers |= VKEY_CAPITAL; + return modifiers; +} + //////////////////////////////////////////////////////////////////////////////// // LocatedEvent, protected: diff --git a/ui/views/events/event.h b/ui/views/events/event.h index fc0a0d6..d8ad17f 100644 --- a/ui/views/events/event.h +++ b/ui/views/events/event.h @@ -57,6 +57,10 @@ class Event { bool IsCapsLockDown() const { return (flags_ & EF_CAPS_LOCK_DOWN) != 0; } bool IsAltDown() const { return (flags_ & EF_ALT_DOWN) != 0; } + // Return a mask of active modifier keycodes from + // ui/base/keycodes/keyboard_codes.h + int GetModifiers() const; + // Returns true if the event is any kind of mouse event. bool IsMouseEvent() const { return type_ == ET_MOUSE_PRESSED || |